From 5b2658327d676453e8a251ffc3273f4a218fb278 Mon Sep 17 00:00:00 2001
From: yellow-shine <sammy.huang@zilliz.com>
Date: Sat, 12 Oct 2024 10:41:25 +0800
Subject: [PATCH] enhance: change way to bump milvus bersion (#36776)

Signed-off-by: Yellow Shine <sammy.huang@zilliz.com>
---
 ...sion-only-for-standalone-embed-milvus.yaml | 46 +++++++++++++++++++
 .github/workflows/bump-version.yaml           | 15 ++----
 2 files changed, 51 insertions(+), 10 deletions(-)
 create mode 100644 .github/workflows/bump-version-only-for-standalone-embed-milvus.yaml

diff --git a/.github/workflows/bump-version-only-for-standalone-embed-milvus.yaml b/.github/workflows/bump-version-only-for-standalone-embed-milvus.yaml
new file mode 100644
index 0000000000000..fb80e75150965
--- /dev/null
+++ b/.github/workflows/bump-version-only-for-standalone-embed-milvus.yaml
@@ -0,0 +1,46 @@
+name: Bump Standalone Embed Milvus Version
+
+on:
+  workflow_dispatch:
+    inputs:
+      imageTag:
+        description: "the milvus image tag"
+        required: true
+        type: string
+
+jobs:
+  update-knowhere-commits:
+    name: Bump Milvus Version for release
+    runs-on: ubuntu-latest
+    timeout-minutes: 20
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+      - name: Update milvus image tag
+        # continue-on-error: true
+        shell: bash
+        run: |
+          sed -i 's/\(milvusdb\/milvus:\)[^[:space:]]*/\1${{ inputs.imageTag }}/' scripts/standalone_embed.sh
+          git config --local user.email "41898282+github-actions[bot]@users.noreply.github.com"
+          git config --local user.name "github-actions[bot]"
+          git add scripts
+          git status
+          git commit -m "Bump milvus version to ${{ inputs.imageTag }}"
+      - name: Create Pull Request
+        id: cpr
+        continue-on-error: true
+        uses: peter-evans/create-pull-request@v3
+        with:
+          token: ${{ secrets.ALL_CONTRIBUTORS_TOKEN }}
+          author: sre-ci-robot <sre-ci-robot@users.noreply.github.com>
+          signoff: true
+          branch: bump_milvus_commit_${{ github.sha }}
+          delete-branch: true
+          title: '[automated] Bump milvus version to ${{ inputs.imageTag }}'
+          body: |
+            Bump milvus version to ${{ inputs.imageTag }}
+            Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com
+      - name: Check outputs
+        run: |
+          echo "Pull Request Number - ${{ steps.cpr.outputs.pull-request-number }}"
+          echo "Pull Request URL - ${{ steps.cpr.outputs.pull-request-url }}"
diff --git a/.github/workflows/bump-version.yaml b/.github/workflows/bump-version.yaml
index f7e138538a23b..9a46a7adac4cb 100644
--- a/.github/workflows/bump-version.yaml
+++ b/.github/workflows/bump-version.yaml
@@ -7,10 +7,6 @@ on:
         description: "the milvus image tag"
         required: true
         type: string
-      oldImageTag:
-        description: "the milvus old image tag"
-        required: true
-        type: string
 
 jobs:
   update-knowhere-commits:
@@ -24,15 +20,14 @@ jobs:
         # continue-on-error: true
         shell: bash
         run: |
-          # sed -i "s#( image: milvusdb/milvus:.*#( image: milvusdb/milvus:${{ inputs.imageTag }} )#g" deployments/docker/standalone/docker-compose.yml
-          sed -i "s/milvusdb\/milvus:${{ inputs.oldImageTag }}/milvusdb\/milvus:${{ inputs.imageTag }}/g" deployments/docker/standalone/docker-compose.yml
-          sed -i "s/milvusdb\/milvus:${{ inputs.oldImageTag }}/milvusdb\/milvus:${{ inputs.imageTag }}/g" deployments/binary/README.md
-          sed -i "s/milvusdb\/milvus:${{ inputs.oldImageTag }}/milvusdb\/milvus:${{ inputs.imageTag }}/g" deployments/docker/gpu/standalone/docker-compose.yml
-          sed -i "s/milvusdb\/milvus:${{ inputs.oldImageTag }}/milvusdb\/milvus:${{ inputs.imageTag }}/g" deployments/docker/cluster-distributed-deployment/inventory.ini
+          sed -i 's/\(milvusdb\/milvus:\)[^[:space:]]*/\1${{ inputs.imageTag }}/' deployments/docker/standalone/docker-compose.yml
+          sed -i 's/\(milvusdb\/milvus:\)[^[:space:]]*/\1${{ inputs.imageTag }}/' deployments/binary/README.md
+          sed -i 's/\(milvusdb\/milvus:\)[^[:space:]]*-gpu/\1${{ inputs.imageTag }}-gpu/' deployments/docker/gpu/standalone/docker-compose.yml
+          sed -i 's/\(milvusdb\/milvus:\)[^[:space:]]*/\1${{ inputs.imageTag }}/' deployments/docker/cluster-distributed-deployment/inventory.ini
           git config --local user.email "41898282+github-actions[bot]@users.noreply.github.com"
           git config --local user.name "github-actions[bot]"
+          git diff
           git add deployments
-          git status
           git commit -m "Bump milvus version to ${{ inputs.imageTag }}"
       - name: Create Pull Request
         id: cpr