enhance: [bitset] multiple 'and' and 'or' in a single op #33345

alexanderguzhva · 2024-05-24T01:39:56Z

Refactoring
Added a capability to perform multiple bitwise and and or operations in a single op
AVX2, AVX512, ARM NEON, ARM SVE backed bitwise and, op, xor and sub ops
more unit tests for bitset
fixed a bug in or_with_count for certain bitset sizes
fixed a bug for certain offset values for inplace operations that take two bitsets

mergify · 2024-05-24T01:40:32Z

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

Title Format: The PR title must begin with one of these prefixes:

feat: for introducing a new feature.
fix: for bug fixes.
enhance: for improvements to existing functionality.
test: for add tests to existing functionality.
doc: for modifying documentation.
auto: for the pull request from bot.

Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

mergify · 2024-05-24T01:45:08Z

@alexanderguzhva Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

mergify · 2024-05-24T02:19:45Z

@alexanderguzhva ut workflow job failed, comment rerun ut can trigger the job again.

codecov · 2024-05-24T04:01:11Z

Codecov Report

Attention: Patch coverage is 83.21168% with 69 lines in your changes missing coverage. Please review.

Project coverage is 80.70%. Comparing base (2e76709) to head (cb02da7).
Report is 10 commits behind head on master.

Files with missing lines	Patch %	Lines
.../core/src/bitset/detail/platform/x86/avx512-impl.h	0.00%	36 Missing ⚠️
...al/core/src/bitset/detail/platform/x86/avx2-impl.h	50.00%	18 Missing ⚠️
...l/core/src/bitset/detail/platform/vectorized_ref.h	0.00%	12 Missing ⚠️
internal/core/src/bitset/detail/maybe_vector.h	83.33%	2 Missing ⚠️
...ternal/core/src/bitset/detail/platform/dynamic.cpp	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #33345      +/-   ##
==========================================
+ Coverage   72.34%   80.70%   +8.36%     
==========================================
  Files        1310     1311       +1     
  Lines      183596   183979     +383     
==========================================
+ Hits       132819   148480   +15661     
+ Misses      45658    30389   -15269     
+ Partials     5119     5110       -9

Files with missing lines	Coverage Δ
internal/core/src/bitset/bitset.h	`99.68% <100.00%> (+21.17%)`	⬆️
internal/core/src/bitset/common.h	`100.00% <ø> (ø)`
internal/core/src/bitset/detail/bit_wise.h	`100.00% <100.00%> (ø)`
...ternal/core/src/bitset/detail/element_vectorized.h	`97.24% <100.00%> (+10.41%)`	⬆️
internal/core/src/bitset/detail/element_wise.h	`100.00% <100.00%> (+26.73%)`	⬆️
internal/core/src/bitset/detail/platform/dynamic.h	`100.00% <100.00%> (ø)`
internal/core/src/bitset/detail/proxy.h	`100.00% <100.00%> (+25.00%)`	⬆️
...ternal/core/src/bitset/detail/platform/dynamic.cpp	`68.00% <66.66%> (+68.00%)`	⬆️
internal/core/src/bitset/detail/maybe_vector.h	`83.33% <83.33%> (ø)`
...l/core/src/bitset/detail/platform/vectorized_ref.h	`0.00% <0.00%> (ø)`
... and 2 more

... and 257 files with indirect coverage changes

mergify · 2024-05-24T16:21:11Z

@alexanderguzhva ut workflow job failed, comment rerun ut can trigger the job again.

zhagnlu · 2024-06-07T08:54:29Z

/lgtm

alexanderguzhva · 2024-06-24T21:46:09Z

/hold

mergify · 2024-10-17T00:00:02Z

@alexanderguzhva E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

alexanderguzhva · 2024-10-17T00:14:17Z

/unhold

mergify · 2024-10-17T00:38:46Z

@alexanderguzhva E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2024-10-17T00:38:46Z

@alexanderguzhva go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify · 2024-10-17T01:03:56Z

@alexanderguzhva E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2024-10-17T01:16:10Z

@alexanderguzhva go-sdk check failed, comment rerun go-sdk can trigger the job again.

alexanderguzhva · 2024-10-17T01:41:12Z

/run-cpu-e2e

alexanderguzhva · 2024-10-17T01:41:23Z

rerun go-sdk

mergify · 2024-10-17T02:05:13Z

@alexanderguzhva E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2024-10-17T02:05:14Z

@alexanderguzhva go-sdk check failed, comment rerun go-sdk can trigger the job again.

alexanderguzhva · 2024-10-17T11:15:29Z

rerun go-sdk

alexanderguzhva · 2024-10-17T11:17:05Z

/run-cpu-e2e

Signed-off-by: Alexandr Guzhva <[email protected]>

mergify · 2024-10-18T12:25:00Z

@alexanderguzhva go-sdk check failed, comment rerun go-sdk can trigger the job again.

alexanderguzhva · 2024-10-18T14:08:24Z

@zhagnlu @liliu-z please help reviewing

alexanderguzhva · 2024-10-18T16:02:42Z

rerun go-sdk

czs007 · 2024-10-22T08:24:08Z

/approve
/lgtm

sre-ci-robot · 2024-10-22T08:24:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~internal/core/OWNERS~~ [czs007]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

issue: #34117 pr: #33345 Refactoring: * Added a capability to perform multiple bitwise and and or operations in a single op * AVX2, AVX512, ARM NEON, ARM SVE backed bitwise and, op, xor and sub ops * more unit tests for bitset * fixed a bug in or_with_count for certain bitset sizes * fixed a bug for certain offset values for inplace operations that take two bitsets Signed-off-by: Alexandr Guzhva <[email protected]>

sre-ci-robot added the do-not-merge/work-in-progress Don't merge even CI passed. label May 24, 2024

sre-ci-robot requested review from czs007 and godchen0212 May 24, 2024 01:40

sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label May 24, 2024

mergify bot added dco-passed DCO check passed. do-not-merge/invalid-pr-format labels May 24, 2024

alexanderguzhva changed the title ~~[WIP] bitset: multiple 'and' and 'or' in a single op~~ [enhance] [WIP] bitset: multiple 'and' and 'or' in a single op May 24, 2024

sre-ci-robot removed the do-not-merge/work-in-progress Don't merge even CI passed. label May 24, 2024

alexanderguzhva changed the title ~~[enhance] [WIP] bitset: multiple 'and' and 'or' in a single op~~ enhance: [WIP] bitset: multiple 'and' and 'or' in a single op May 24, 2024

mergify bot added kind/enhancement Issues or changes related to enhancement do-not-merge/missing-related-issue and removed do-not-merge/invalid-pr-format labels May 24, 2024

alexanderguzhva force-pushed the bitset_multiple_and_or branch from ac54891 to 14c3828 Compare May 24, 2024 01:46

alexanderguzhva force-pushed the bitset_multiple_and_or branch from 14c3828 to 25ef68f Compare May 24, 2024 15:32

alexanderguzhva force-pushed the bitset_multiple_and_or branch from 25ef68f to dbe3e7d Compare May 24, 2024 21:12

alexanderguzhva changed the title ~~enhance: [WIP] bitset: multiple 'and' and 'or' in a single op~~ enhance: [bitset] multiple 'and' and 'or' in a single op May 24, 2024

mergify bot added the ci-passed label May 24, 2024

sre-ci-robot assigned zhagnlu Jun 7, 2024

sre-ci-robot added the lgtm label Jun 7, 2024

mergify bot added ci-passed and removed do-not-merge/missing-related-issue ci-passed labels Jun 24, 2024

sre-ci-robot added the do-not-merge/hold label Jun 24, 2024

alexanderguzhva force-pushed the bitset_multiple_and_or branch from fb5c63c to 7faad85 Compare October 17, 2024 00:12

sre-ci-robot removed the do-not-merge/hold label Oct 17, 2024

alexanderguzhva force-pushed the bitset_multiple_and_or branch from 7faad85 to 42f00db Compare October 17, 2024 00:51

alexanderguzhva force-pushed the bitset_multiple_and_or branch from 42f00db to c6cbc61 Compare October 17, 2024 12:43

alexanderguzhva mentioned this pull request Oct 17, 2024

enhance: [2.4][bitset] multiple 'and' and 'or' in a single op #36973

Merged

bitset: multiple 'and' and 'or' in a single op

cb02da7

Signed-off-by: Alexandr Guzhva <[email protected]>

alexanderguzhva force-pushed the bitset_multiple_and_or branch from c6cbc61 to cb02da7 Compare October 18, 2024 12:00

mergify bot added the ci-passed label Oct 18, 2024

sre-ci-robot assigned czs007 Oct 22, 2024

sre-ci-robot added the lgtm label Oct 22, 2024

sre-ci-robot added the approved label Oct 22, 2024

sre-ci-robot merged commit 5a1f752 into milvus-io:master Oct 22, 2024
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enhance: [bitset] multiple 'and' and 'or' in a single op #33345

enhance: [bitset] multiple 'and' and 'or' in a single op #33345

alexanderguzhva commented May 24, 2024 •

edited

Loading

mergify bot commented May 24, 2024

mergify bot commented May 24, 2024

mergify bot commented May 24, 2024

codecov bot commented May 24, 2024 •

edited

Loading

mergify bot commented May 24, 2024

zhagnlu commented Jun 7, 2024

alexanderguzhva commented Jun 24, 2024

mergify bot commented Oct 17, 2024

alexanderguzhva commented Oct 17, 2024

mergify bot commented Oct 17, 2024

mergify bot commented Oct 17, 2024

mergify bot commented Oct 17, 2024

mergify bot commented Oct 17, 2024

alexanderguzhva commented Oct 17, 2024

alexanderguzhva commented Oct 17, 2024

mergify bot commented Oct 17, 2024

mergify bot commented Oct 17, 2024

alexanderguzhva commented Oct 17, 2024

alexanderguzhva commented Oct 17, 2024

mergify bot commented Oct 18, 2024

alexanderguzhva commented Oct 18, 2024

alexanderguzhva commented Oct 18, 2024

czs007 commented Oct 22, 2024

sre-ci-robot commented Oct 22, 2024

enhance: [bitset] multiple 'and' and 'or' in a single op #33345

enhance: [bitset] multiple 'and' and 'or' in a single op #33345

Conversation

alexanderguzhva commented May 24, 2024 • edited Loading

mergify bot commented May 24, 2024

mergify bot commented May 24, 2024

mergify bot commented May 24, 2024

codecov bot commented May 24, 2024 • edited Loading

Codecov Report

mergify bot commented May 24, 2024

zhagnlu commented Jun 7, 2024

alexanderguzhva commented Jun 24, 2024

mergify bot commented Oct 17, 2024

alexanderguzhva commented Oct 17, 2024

mergify bot commented Oct 17, 2024

mergify bot commented Oct 17, 2024

mergify bot commented Oct 17, 2024

mergify bot commented Oct 17, 2024

alexanderguzhva commented Oct 17, 2024

alexanderguzhva commented Oct 17, 2024

mergify bot commented Oct 17, 2024

mergify bot commented Oct 17, 2024

alexanderguzhva commented Oct 17, 2024

alexanderguzhva commented Oct 17, 2024

mergify bot commented Oct 18, 2024

alexanderguzhva commented Oct 18, 2024

alexanderguzhva commented Oct 18, 2024

czs007 commented Oct 22, 2024

sre-ci-robot commented Oct 22, 2024

alexanderguzhva commented May 24, 2024 •

edited

Loading

codecov bot commented May 24, 2024 •

edited

Loading