Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return error if searching against BM25 output field with incorrect metric type #36910

Merged

Conversation

zhengbuqian
Copy link
Contributor

issue: #36835

currently searching BM25 output field using IP will end up in an error in segcore which is hard to understand. now returning error in query node delegator and provide more useful error message

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@72dc07b). Learn more about missing BASE report.
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/task_index.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36910   +/-   ##
=========================================
  Coverage          ?   81.52%           
=========================================
  Files             ?     1308           
  Lines             ?   156236           
  Branches          ?        0           
=========================================
  Hits              ?   127371           
  Misses            ?    23754           
  Partials          ?     5111           
Files with missing lines Coverage Δ
internal/querynodev2/delegator/delegator.go 87.14% <100.00%> (ø)
internal/proxy/task_index.go 80.53% <0.00%> (ø)

@aoiasd
Copy link
Contributor

aoiasd commented Oct 16, 2024

/lgtm

@czs007
Copy link
Collaborator

czs007 commented Oct 16, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 06b5e18 into milvus-io:master Oct 16, 2024
15 of 16 checks passed
@zhengbuqian zhengbuqian deleted the doc-in-invalid-search-metric-type branch October 17, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants