Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge sort segment loss data #37400

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Nov 4, 2024

relate: #37238

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 4, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 4, 2024
Copy link
Contributor

mergify bot commented Nov 4, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 4, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (b3de4b0) to head (f3b48d1).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
internal/datanode/compaction/merge_sort.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37400      +/-   ##
==========================================
- Coverage   83.25%   81.03%   -2.23%     
==========================================
  Files        1015     1305     +290     
  Lines      157480   182857   +25377     
==========================================
+ Hits       131116   148172   +17056     
- Misses      21172    29483    +8311     
- Partials     5192     5202      +10     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.37% <ø> (∅)
Go 83.25% <0.00%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
internal/datanode/compaction/merge_sort.go 78.94% <0.00%> (-0.19%) ⬇️

... and 317 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Nov 6, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Nov 6, 2024

rerun go-sdk

1 similar comment
@aoiasd
Copy link
Contributor Author

aoiasd commented Nov 6, 2024

rerun go-sdk

Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b4c749d into milvus-io:master Nov 7, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants