-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: rename tokenizer to analyzer #37478
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aoiasd The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@aoiasd go-sdk check failed, comment |
@aoiasd E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #37478 +/- ##
===========================================
- Coverage 83.23% 67.30% -15.94%
===========================================
Files 1015 290 -725
Lines 157697 25400 -132297
===========================================
- Hits 131260 17095 -114165
+ Misses 21228 8305 -12923
+ Partials 5209 0 -5209
|
@@ -20,7 +20,7 @@ | |||
namespace milvus { | |||
TokenizerParams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename method and type name as well: TokenizerParams
and ParseTokenizerParams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next pr, all tokenizer in segcore and go code shoud rename to analyzer, but this pr just rename user params.
eaa2abb
to
f38c5dc
Compare
@aoiasd E2e jenkins job failed, comment |
Signed-off-by: aoiasd <[email protected]>
f38c5dc
to
f6f1cd6
Compare
relate: #35853