Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: rename tokenizer to analyzer #37478

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Nov 6, 2024

relate: #35853

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aoiasd
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. area/test sig/testing labels Nov 6, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 6, 2024
Copy link
Contributor

mergify bot commented Nov 6, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 6, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.30%. Comparing base (7cfd609) to head (f38c5dc).
Report is 15 commits behind head on master.

Current head f38c5dc differs from pull request most recent head f6f1cd6

Please upload reports for the commit f6f1cd6 to get more accurate results.

Files with missing lines Patch % Lines
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% 4 Missing ⚠️
internal/core/src/index/TextMatchIndex.cpp 60.00% 2 Missing ⚠️
internal/core/src/segcore/SegmentSealedImpl.cpp 50.00% 2 Missing ⚠️
internal/core/src/indexbuilder/index_c.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37478       +/-   ##
===========================================
- Coverage   83.23%   67.30%   -15.94%     
===========================================
  Files        1015      290      -725     
  Lines      157697    25400   -132297     
===========================================
- Hits       131260    17095   -114165     
+ Misses      21228     8305    -12923     
+ Partials     5209        0     -5209     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.30% <50.56%> (∅)
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/common/FieldMeta.cpp 76.66% <100.00%> (ø)
internal/core/src/common/FieldMeta.h 94.64% <ø> (ø)
internal/core/src/common/Schema.h 98.41% <ø> (ø)
internal/core/src/segcore/SegmentGrowingImpl.cpp 77.49% <100.00%> (ø)
internal/core/src/indexbuilder/index_c.cpp 24.66% <0.00%> (ø)
internal/core/src/index/TextMatchIndex.cpp 45.53% <60.00%> (ø)
internal/core/src/segcore/SegmentSealedImpl.cpp 85.93% <50.00%> (ø)
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% <0.00%> (ø)

... and 1297 files with indirect coverage changes

@@ -20,7 +20,7 @@
namespace milvus {
TokenizerParams
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename method and type name as well: TokenizerParams and ParseTokenizerParams

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next pr, all tokenizer in segcore and go code shoud rename to analyzer, but this pr just rename user params.

Copy link
Contributor

mergify bot commented Nov 7, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement sig/testing size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants