-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: avoid memory copy and serde in mix compaction #37479
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tedxu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In this PR, the serialization / deserialization operations and memory copies are avoided in mix compaction. From which, the mix compaction performance is improved significantly. See benchmark results below: Before:
After
|
@tedxu E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #37479 +/- ##
===========================================
+ Coverage 67.31% 82.56% +15.24%
===========================================
Files 290 1043 +753
Lines 25377 161159 +135782
===========================================
+ Hits 17082 133056 +115974
- Misses 8295 22841 +14546
- Partials 0 5262 +5262
|
/lgtm |
Signed-off-by: Ted Xu <[email protected]>
Signed-off-by: Ted Xu <[email protected]>
Signed-off-by: Ted Xu <[email protected]>
d2c18ad
to
b5b66db
Compare
New changes are detected. LGTM label has been removed. |
@tedxu cpp-unit-test check failed, comment |
@tedxu E2e jenkins job failed, comment |
rerun cpp-unit-test |
/run-cpu-e2e |
@tedxu E2e jenkins job failed, comment |
See: #37234