Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine group_strict_size parameter(#37482) #37483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MrPresent-Han
Copy link
Contributor

related: #37482

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 6, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Nov 6, 2024
Copy link
Contributor

mergify bot commented Nov 6, 2024

@MrPresent-Han

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Nov 6, 2024
Copy link
Contributor

mergify bot commented Nov 6, 2024

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 6, 2024

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 6, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 7, 2024

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 7, 2024

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 7, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 7, 2024

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.59%. Comparing base (8275e40) to head (2f8b015).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
...nternal/distributed/proxy/httpserver/handler_v2.go 0.00% 2 Missing ⚠️
internal/proxy/search_util.go 93.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37483       +/-   ##
===========================================
+ Coverage   67.31%   82.59%   +15.28%     
===========================================
  Files         290     1043      +753     
  Lines       25377   161590   +136213     
===========================================
+ Hits        17082   133471   +116389     
- Misses       8295    22840    +14545     
- Partials        0     5279     +5279     
Components Coverage Δ
Client 52.03% <ø> (∅)
Core ∅ <ø> (∅)
Go 83.24% <82.35%> (∅)
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/request_v2.go 100.00% <ø> (ø)
internal/proxy/task.go 87.05% <ø> (ø)
internal/proxy/search_util.go 81.36% <93.33%> (ø)
...nternal/distributed/proxy/httpserver/handler_v2.go 91.52% <0.00%> (ø)

... and 1329 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Nov 7, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrPresent-Han
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Nov 7, 2024
Copy link
Contributor

mergify bot commented Nov 7, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 7, 2024

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 7, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 7, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test dco-passed DCO check passed. do-not-merge/invalid-pr-format sig/testing size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants