Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Planning: Grin v4.0.0 #248

Closed
lehnberg opened this issue Jan 24, 2020 · 4 comments
Closed

Release Planning: Grin v4.0.0 #248

lehnberg opened this issue Jan 24, 2020 · 4 comments
Labels
development Anything related to development fixed pm Anything related to project management task An action that needs to be taken

Comments

@lehnberg
Copy link
Collaborator

lehnberg commented Jan 24, 2020

Planning issue for version 4.0.0 of grin and grin-wallet, which is to support the scheduled network-wide upgrade occurring at block 786,240, around July 15, 2020.

Scope freeze

Scope was agreed and finalised in the Mar 31 dev meeting.

Target release date

Beta: June 02, 2020
Release candidate: June 16, 2020
Floonet hard fork: June 20, 2020
Final release: June 30, 2020

Discussion

Planning discussion can be had asynchronously on this issue, or in development sub-teams on keybase.

Definitions

P1 - Critical
P2 - Important
P3 - Fix if time

📝: awaiting specification
🛠: in progress
✅: merged
🔍: awaiting review


Milestones

Items

Make suggestions by commenting in issue, preferably with a motivation and a proposed priority.

# Prio Team Description Owner Reference Status
1 P1 Node Cuckaroo tweak @tromp mimblewimble/grin#3286
mimblewimble/grin#3334
2 P1 Wallet Compact slates @yeastplume mimblewimble/grin-wallet#317
mimblewimble/grin-rfcs#49
mimblewimble/grin-wallet#404
3 P1 Wallet Slatepack @j01tz, @yeastplume mimblewimble/grin-wallet#406
mimblewimble/grin-wallet#410
mimblewimble/grin-wallet#411 mimblewimble/grin-rfcs#55
🛠
5 P2 Node Deprecate Node API v1 @quentinlesceller mimblewimble/grin#3287
mimblewimble/grin#3310
6 P2 Node Relative Kernel Locks @antiochp mimblewimble/grin-rfcs#19
mimblewimble/grin#3288
mimblewimble/grin#3303
mimblewimble/grin#3302
🛠
7 P2 Wallet Improved offset selection @yeastplume mimblewimble/grin-wallet#405
mimblewimble/grin-wallet#407
8 P2 Wallet remove wallet owner api v2 @yeastplume mimblewimble/grin-wallet#373
9 P3 Wallet Announce deprecation for running http listener for external addresses @yeastplume mimblewimble/grin-wallet#66

Out of scope

# Priority Team Description Reference Motivation
2 P2 Node Duplicate outputs mimblewimble/grin#3271 Targeted for 5.0.0 for now
9 P? Node Full chain archive sync at protocol level mimblewimble/grin#3092 No dev taking task for 4.0.0. Not consensus breaking, can be done in future release.
4 P1 Node Parallell IBD mimblewimble/grin#3289
mimblewimble/grin-rfcs#52
Dev is on leave
@lehnberg lehnberg added task An action that needs to be taken development Anything related to development pm Anything related to project management labels Jan 24, 2020
@antiochp
Copy link
Member

antiochp commented Mar 14, 2020

Mentioned #261 (comment) but cross posting here -

We should consider breaking out "allow duplicate outputs" as a separate topic from "relative kernels" as it is a consensus breaking change on its own. It looks increasingly like it is a requirement for any of the current "relative kernel" proposals to be useful in practice.

Added issue here - mimblewimble/grin#3271

This likely deserves its own RFC but tracking as an issue initially.

One of the reasons for bringing this up is the new "state of the art" in NRD kernels is still early and we probably do not want to rush this in for 4.0.0 unless we are actually confident this will work and is fit for purpose.
We do know with reasonable certainty how to approach "allow duplicate outputs".
And I'd much prefer getting one of these consensus breaking changes in for 4.0.0 vs. delaying kernel locks and neither making it in.

@MCM-Mike
Copy link

Please also discuss the following request : mimblewimble/grin#3092

Full chain archive sync at protocol level #3092
If it could be implemented in the next Hard Fork or the last Hard Fork

As well I would like to be discussed is the current and upcoming Wallet-API versions.
You did announce the "Deprecate Node API v1" .
Couple of questions regarding wallet-api which you could clarify and make it more visible:

These are some important questions we need to make public, because a lot of people are building on the API applications and services.

@jaspervdm
Copy link
Contributor

@MCM-Mike

will APIv1 be deprecated with version 4.0?

v1 API has already been previously deprecated and subsequently removed in wallet v2.0.0, see this PR.

which APIvX will replace the current still working APIv1? is it APIv2 or APIv3 ?

v1 wallet API doesn't work anymore, since it has been removed already in wallet 2.0.0.
v2 wallet owner API has been deprecated since wallet 3.0.0, to be removed in 4.0.0.
It is replaced by the v3 (secure) owner API, originally released in wallet 2.1.0, see this PR.

When are you going to release APIv3 ? https://docs.rs/grin_wallet_api/3.0.0/grin_wallet_api/

APIv3 has been out since wallet 2.1.0. You can find its documentation at https://docs.rs/grin_wallet_api/3.1.0/grin_wallet_api/trait.OwnerRpcS.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Anything related to development fixed pm Anything related to project management task An action that needs to be taken
Projects
None yet
Development

No branches or pull requests

5 participants
@jaspervdm @MCM-Mike @lehnberg @antiochp and others