-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR commented on multiple times #1949
Comments
Going to try and recreate this locally. Perhaps it has something to do with the force pushes? |
Thanks @gregfurman! Feel free to reach out if you have any questions. |
Think I found the issue. The GitHub API returns reviews from earliest to latest. We iterate through all review objects and when we encounter the first whose body contains the So if HEAD of the PR was
See below snippet showing list of reviews that would return early: See Line 264 in below code snippet which would always be false after the first minder review was made thus the "previois review" is never kept and we always submit a new one: Going to write some tests to confirm this is the case and make a PR tomorrow sometime. The solution probably just requires us to iterate through reviews in reverse order from how the API currently returns them (so latest to earliest). Full Results of GitHub API CallsGitHub API Reviews for PR 1790
GitHub API Commits for PR 1790
|
Sure! Closing this issue in favor of #1862 |
Describe the issue
We sometimes add multiple comments that tell that minder has analysed a PR. We should only be adding one and there already should be a safeguard looking for a magic comment in the previous PR but that is apparently not working correctly.
To Reproduce
Unsure yet, but manifested at #1790 (review)
What version are you using?
today's master (stacklok staging)
The text was updated successfully, but these errors were encountered: