Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--owner flag value is not validated while enrolling a provider #2723

Closed
rdimitrov opened this issue Mar 20, 2024 · 1 comment
Closed

--owner flag value is not validated while enrolling a provider #2723

rdimitrov opened this issue Mar 20, 2024 · 1 comment
Assignees
Labels
bug Something isn't working cli go Pull requests that update Go code help wanted Extra attention is needed

Comments

@rdimitrov
Copy link
Member

We still get the Provider enrolled successfully message even if we pass a non-existing org value while enrolling a provider via the --owner flag.

@rdimitrov rdimitrov added bug Something isn't working help wanted Extra attention is needed cli go Pull requests that update Go code labels Mar 20, 2024
@psekar
Copy link
Contributor

psekar commented Jul 10, 2024

Hello @rdimitrov
I would like to contribute to this bug fix. Below is the question that i would like to get clarified before sending the fix.

We could validate if the users access token can get the organization API during provider enrollment. Incase of the API failure with 404 due to non-existing gh org, should i invoke delete provider workflow ?

Thanks for your guidance 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli go Pull requests that update Go code help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants