Skip to content
This repository has been archived by the owner on Apr 2, 2019. It is now read-only.

Add twitter block #6

Open
MarcStoecker opened this issue Apr 26, 2014 · 3 comments
Open

Add twitter block #6

MarcStoecker opened this issue Apr 26, 2014 · 3 comments

Comments

@MarcStoecker
Copy link
Contributor

Since the beginning the twitter block (part of Sir Trevor's default blocks) is missing from the package. There is no reason for not supporting it.

@abjerner
Copy link
Contributor

The Twitter part requires some server side logic to work. I already have this in my SirTrevor package for Umbraco 6, so I'll look into creating a pull request when I can find the time.

I don't know your take on third party DLLs, but my current code will require a reference to my Skybrud.Social framework to handle the Twitter stuff https://github.com/abjerner/Skybrud.Social

Let me know what your think ;)

@MarcStoecker
Copy link
Contributor Author

Hey Anders, that is a great idea! I'm very much for collaborating. Your library seems to be under MIT, so that would be fitting. Could you do a PR with just the ST-block, the WebAPI (or whatever) plus your lib? Maybe we could to that on a WIP/dev branch? What would be your take?

@abjerner
Copy link
Contributor

Yes, my library is released under MIT ;)

I'll look into implementing this over the weekend. I can't remember exactly how much Twitter configuration is needed, so if simple, I'll create another pull request - otherwise we can go with a branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants