From 5a2dad9cb4d36907f969db975e8c7cdb9c65e087 Mon Sep 17 00:00:00 2001 From: Soren Martius Date: Tue, 10 May 2022 12:57:27 +0100 Subject: [PATCH 1/2] fix: var.app_installations should be of type set(string) instead of set(number) --- CHANGELOG.md | 4 ++++ README.md | 4 ++-- README.tfdoc.hcl | 4 ++-- test/unit-complete/variables.tf | 2 +- variables.tf | 2 +- 5 files changed, 10 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e6775a4..fbae664 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Fixed + +- `var.app_installations` should be a of type `set(string)` instead of `set(number)` + ## [0.16.1] ### Added diff --git a/README.md b/README.md index 11103d8..fd94bcf 100644 --- a/README.md +++ b/README.md @@ -811,7 +811,7 @@ This is due to some terraform limitation and we will update the module once terr #### App Installations -- [**`app_installations`**](#var-app_installations): *(Optional `set(number)`)* +- [**`app_installations`**](#var-app_installations): *(Optional `set(string)`)* A set of GitHub App IDs to be installed in this repository. @@ -820,7 +820,7 @@ This is due to some terraform limitation and we will update the module once terr Example: ```hcl - app_installations = [25405144, 12556423] + app_installations = ["05405144", "12556423"] ``` ### Module Configuration diff --git a/README.tfdoc.hcl b/README.tfdoc.hcl index 63db983..20d27c4 100644 --- a/README.tfdoc.hcl +++ b/README.tfdoc.hcl @@ -1057,14 +1057,14 @@ section { title = "App Installations" variable "app_installations" { - type = set(number) + type = set(string) default = {} description = <<-END A set of GitHub App IDs to be installed in this repository. END readme_example = <<-END - app_installations = [25405144, 12556423] + app_installations = ["05405144", "12556423"] END } } diff --git a/test/unit-complete/variables.tf b/test/unit-complete/variables.tf index b7c235b..fab5130 100644 --- a/test/unit-complete/variables.tf +++ b/test/unit-complete/variables.tf @@ -257,7 +257,7 @@ variable "autolink_references" { } variable "app_installations" { - type = set(number) + type = set(string) description = "A list of GitHub App IDs to be installed in this repository." default = [] } diff --git a/variables.tf b/variables.tf index 933a3c1..3eac082 100644 --- a/variables.tf +++ b/variables.tf @@ -529,7 +529,7 @@ variable "archive_on_destroy" { } variable "app_installations" { - type = set(number) + type = set(string) description = "(Optional) A list of GitHub App IDs to be installed in this repository." default = [] } From 001309acb3482bb78f8151f196b7d9d3fb14dad8 Mon Sep 17 00:00:00 2001 From: Soren Martius Date: Tue, 10 May 2022 22:02:45 +0200 Subject: [PATCH 2/2] chore: prepare v0.16.2 release --- CHANGELOG.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fbae664..44788e5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +## [0.16.2] + ### Fixed - `var.app_installations` should be a of type `set(string)` instead of `set(number)` @@ -378,7 +380,8 @@ Please review plans and report regressions and issues asap so we can improve doc - This is the initial release of our GitHub Repository module with support for creating and managing GitHub Repositories for Organizations. -[unreleased]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.16.1...HEAD +[unreleased]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.16.2...HEAD +[0.16.2]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.16.1...v0.16.2 [0.16.1]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.16.0...v0.16.1 [0.16.0]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.15.0...v0.16.0 [0.15.0]: https://github.com/mineiros-io/terraform-github-repository/compare/v0.14.0...v0.15.0