Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for discussions #153

Open
meddlin opened this issue Mar 30, 2023 · 2 comments
Open

Add support for discussions #153

meddlin opened this issue Mar 30, 2023 · 2 comments

Comments

@meddlin
Copy link

meddlin commented Mar 30, 2023

It would be incredibly helpful to allow this module to support GitHub's Discussions feature, similar to how the has_issues, has_wiki, and has_projects works.

variable "has_issues" {

variable "has_projects" {

variable "has_wiki" {

@meddlin
Copy link
Author

meddlin commented Mar 30, 2023

This PR may be beneficial to this issue: integrations/terraform-provider-github#1443
And this open issue, too: integrations/terraform-provider-github#1442

Apologies for not including this initially. I'm still learning HCL, and this repo's relationship with terraform-provider-github.

@shinenelson
Copy link

shinenelson commented Jul 10, 2023

This feature was introduced in v5.14.0. This means that we would have to bump the minimum provider requirements to >= 5.14.0.

Since #148 is already bumping the minimum provider requirement to >= 5.16.0, and it has other minor boolean changes as well, maybe the changes required to resolve this issue could also be merged in along with it.


Note to maintainers : I offered to obsolete the defaults variable in #148. I could create a pull request that resolves this issue as well according to your preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants