Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for is_alphanumeric in autolink reference #142

Open
mmh opened this issue Nov 23, 2022 · 1 comment · May be fixed by #156
Open

Add support for is_alphanumeric in autolink reference #142

mmh opened this issue Nov 23, 2022 · 1 comment · May be fixed by #156
Assignees
@soerenmartius
Labels
enhancement New feature or request

Comments

@mmh
Copy link

mmh commented Nov 23, 2022

GitHub recently added an option for is_alphanumeric in github_repository_autolink_reference. This was added to v5.8.0 of terraform-github-provider and documented here

Bumping the provider causes a change to all our current autolinks, like below.

-/+ resource "github_repository_autolink_reference" "repository_autolink_reference" {
      + etag                = (known after apply)
      ~ id                  = "346367" -> (known after apply)
      + is_alphanumeric     = true # forces replacement
        # (3 unchanged attributes hidden)
  }

It would be great if autolink_references could be extented to support setting is_alphanumeric.
@soerenmartius soerenmartius self-assigned this Nov 23, 2022
@soerenmartius soerenmartius added the enhancement New feature or request label Nov 23, 2022
@tobiasehlert tobiasehlert linked a pull request Apr 28, 2023 that will close this issue
Open
@tobiasehlert
Copy link

Created PR #156 that adds possibility to set is_alphanumeric inside autolink_reference to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soerenmartius soerenmartius

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for is_alphanumeric in autolink_reference tobiasehlert/terraform-github-repository
3 participants
@mmh @soerenmartius @tobiasehlert