Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 not supported #966

Closed
l4time opened this issue Jan 31, 2024 · 16 comments · Fixed by #972
Closed

Python 3.12 not supported #966

l4time opened this issue Jan 31, 2024 · 16 comments · Fixed by #972
Assignees
Labels
help wanted Extra attention is needed python Pull requests that update Python code status/accepted Accepted proposal

Comments

@l4time
Copy link

l4time commented Jan 31, 2024

Python 3.12 does not seem to be supported as typed-ast library is now EOL and no wheels package exists for python 3.12.

Error message:
ERROR: Failed building wheel for typed-ast Failed to build typed-ast ERROR: Could not build wheels for typed-ast, which is required to install pyproject.toml-based projects

Is there any way to switch over to the ast library as it is now recommended for Python versions above 3.8

@tb102122
Copy link
Contributor

See the relateed suggestion
python/typed_ast#179

@tb102122
Copy link
Contributor

PR created
#972

@endlesslycurious
Copy link

@gabriel-tessier @filipeaaoliveira Apologies for the tag but saw you made commits recently; any chance we can take a look at this PR to fix installations on python versions 3.12 and ideally 3.13 too?

@tb102122
Copy link
Contributor

@endlesslycurious there is no active contribution on the repo. You can submit a PR in the forked repo https://github.com/diagrams-web/diagrams-xtd

@mingrammer mingrammer added help wanted Extra attention is needed status/need-to-review Need to review python Pull requests that update Python code labels Oct 30, 2024
@gabriel-tessier
Copy link
Collaborator

@tb102122
Sorry to not inform you earlier but mingrammer give us collaborator access and we are starting slowly to merge PR and close issues.

More details here:
#1015

I postponed the diagrams-ext fork for now, try to focus and improve here.

@mingrammer
if it's ok to add one more collaborator can you also add @tb102122 he can be really helpful here.

@endlesslycurious
Thanks for the comment it help for triage and set priorities.

@gabriel-tessier gabriel-tessier self-assigned this Oct 30, 2024
@gabriel-tessier gabriel-tessier linked a pull request Oct 30, 2024 that will close this issue
@tb102122
Copy link
Contributor

@gabriel-tessier no problem.
@mingrammer happy to help.

@endlesslycurious
Copy link

That's great news, it seems a useful package that I look forward to trying out!

@endlesslycurious
Copy link

Speaking of priorities it might be worth putting out a minor version (e.g. 0.23.5) with just the fix to get the package working with python 3.12 & 3.13 as currently no python version released in the last year works with this package.

@tb102122
Copy link
Contributor

tb102122 commented Nov 4, 2024

@mingrammer @gabriel-tessier should I update the #972 to also include 3.13 support. 3.12 was tested in the fork https://github.com/diagrams-web/diagrams-xtd already.

@endlesslycurious
Copy link

I see 0.24.0 got released yesterday without the fix for newer python version; anything I can do to help?

@tb102122
Copy link
Contributor

tb102122 commented Nov 6, 2024

I have added the logic for 3.13 as well and resolved the conflicts.

@tb102122
Copy link
Contributor

tb102122 commented Nov 7, 2024

@mingrammer
Copy link
Owner

@tb102122 there seems missing double quote:

typed-ast = { version = "^1.5.5", markers = "python_version < '3.8'}

@tb102122
Copy link
Contributor

tb102122 commented Nov 7, 2024

you are right
#1050

@mingrammer
Copy link
Owner

v0.24.1 is now released.

@endlesslycurious
Copy link

Awesome, confirmed installing successfully for Python 3.13.0 on Mac and 3.11.9 on Windows 11 Pro!

@mingrammer mingrammer added status/accepted Accepted proposal and removed status/need-to-review Need to review labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed python Pull requests that update Python code status/accepted Accepted proposal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants