Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Incorrect XML tag in VersioningConfiguration model #1490

Closed
benjamin3322 opened this issue Sep 22, 2023 · 1 comment
Closed

Bug: Incorrect XML tag in VersioningConfiguration model #1490

benjamin3322 opened this issue Sep 22, 2023 · 1 comment

Comments

@benjamin3322
Copy link
Contributor

Issue description:

The Minio client serializes the VersioningConfiguration model and sends it as XML to an S3 compliant server. However, it defines the XML tag for MfaDelete incorrectly as <MFADelete>, whereas according to the XSD (XML Schema Definition) for S3, it should be <MfaDelete>. This inconsistency in tag naming breaks XML validation when interacting with S3 compliant servers.

Actual Behavior:

The Minio client serializes the VersioningConfiguration model with the incorrect XML tag <MFADelete>, causing XML validation errors when interacting with S3 compliant servers.

Http request

PUT /test-v1?versioning= HTTP/1.1
Host: s3.de.io.cloud.ovh.net
Accept-Encoding: identity
User-Agent: MinIO (Windows 11; amd64) minio-java/8.5.6
Content-MD5: YOx2+B27lj6DTvj0XUcncQ==
x-amz-content-sha256: UNSIGNED-PAYLOAD
x-amz-date: 20230922T132621Z
Authorization: ...

<VersioningConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
<Status>Enabled</Status>
<MFADelete>Disabled</MFADelete>
</VersioningConfiguration>

Http response

HTTP/1.1 400
Content-Type: application/xml
x-amz-id-2: txb8396c6bef054cd19e38f-0000000000
x-amz-request-id: txb8396c6bef054cd19e38f-0000000000
X-Trans-Id: txb8396c6bef054cd19e38f-0000000000
X-Openstack-Request-Id: txb8396c6bef054cd19e38f-0000000000
Date: Fri, 22 Sep 2023 13:27:12 GMT
Transfer-Encoding: chunked
Connection: keep-alive

<?xml version='1.0' encoding='UTF-8'?>
<Error><Code>MalformedXML</Code><Message>The XML you provided was not well-formed or did not validate against our published schema</Message><RequestId>txb8396c6bef054cd19e38f-0000000000</RequestId></Error>

Expected Behavior:

The Minio client should serialize the VersioningConfiguration model with the correct XML tag <MfaDelete> to ensure compatibility with S3 server validation.

Additional Information:

Version : 8.5.6

@benjamin3322
Copy link
Contributor Author

I can close the issue since the PR was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant