From 27ac63977b998e8ff6418d489b5db4a8cb0eda66 Mon Sep 17 00:00:00 2001
From: Krishnan Parthasarathi <krisis@users.noreply.github.com>
Date: Fri, 27 Oct 2017 17:07:55 +0000
Subject: [PATCH] Use uniqid() to generate randomName for buckets (#208)

This will reduce the possibility of bucket names being same across mint
runs on the same (object storage) endpoint.
---
 run/core/aws-sdk-php/quick-tests.php | 24 +++++-------------------
 1 file changed, 5 insertions(+), 19 deletions(-)

diff --git a/run/core/aws-sdk-php/quick-tests.php b/run/core/aws-sdk-php/quick-tests.php
index bdbfff9c..9cbe62ea 100644
--- a/run/core/aws-sdk-php/quick-tests.php
+++ b/run/core/aws-sdk-php/quick-tests.php
@@ -52,27 +52,13 @@ function __construct(string $access_key, string $secret_key, string $host, strin
 }
 
  /**
-  * randomName returns a string of random characters picked from 0-9,a-z.
+  * randomName returns a name prefixed by aws-sdk-php using uniqid()
+  * from standard library
   *
-  * By default it returns a random name of length 5.
-  *
-  * @param int $length - length of random name.
-  *
-  * @return void
+  * @return string
   */
-function randomName(int $length=5):string {
-    $alphabet = array_rand(str_split('0123456789abcdefghijklmnopqrstuvwxyz'), 26);
-    $alphaLen = count($alphabet);
-    $rounds = floor($length / $alphaLen);
-    $remaining = $length % $alphaLen;
-    $bigalphabet = [];
-    for ($i = 0; $i < $rounds; $i++) {
-        $bigalphabet = array_merge($bigalphabet, $alphabet);
-    }
-    $bigalphabet = array_merge($bigalphabet, array_slice($alphabet, 0, $remaining));
-    $alphabet_soup = array_flip($bigalphabet);
-    shuffle($alphabet_soup);
-    return 'aws-sdk-php-bucket-' . join($alphabet_soup);
+function randomName():string {
+    return uniqid("aws-sdk-php-");
 }
 
  /**