Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional ruby tests in mint #62

Closed
deekoder opened this issue Jun 30, 2017 · 2 comments
Closed

Add additional ruby tests in mint #62

deekoder opened this issue Jun 30, 2017 · 2 comments
Assignees
@ebozduman
Labels
fixed priority: medium
Milestone
Current

Comments

@deekoder
Copy link
Contributor

deekoder commented Jun 30, 2017 •
edited by nitisht
Loading

Add correctness test cases based on aws-ruby to Mint. Tests should be

  • Named and commented to indicate the use case being tested.
  • Access all the public Minio server APIs via aws-ruby.
  • Include one positive case and couple of boundary cases for each API.
  • Use streaming files as preferred way to generate files for testing. (This can be a ref: tests: Use content generation input stream minio-java#586)
  • Use static files only in case where streaming can't be used.
@deekoder deekoder self-assigned this Jun 30, 2017
@deekoder deekoder added this to the Current milestone Jun 30, 2017
@nitisht nitisht assigned ebozduman and unassigned deekoder Jul 7, 2017
@nitisht nitisht mentioned this issue Jul 7, 2017
Closed
@nitisht
Copy link
Contributor

nitisht commented Jul 10, 2017

PR sent for addressing this issue: #87

@nitisht
Copy link
Contributor

nitisht commented Jul 11, 2017

Fixed by #87

@nitisht nitisht closed this as completed Jul 11, 2017
@nitisht nitisht added the fixed label Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebozduman ebozduman

Labels
fixed priority: medium
Projects
None yet
Milestone
Current
Development

No branches or pull requests
3 participants
@deekoder @nitisht @ebozduman