Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic widgets not working #72

Closed
minrk opened this issue Aug 11, 2018 · 12 comments
Closed

basic widgets not working #72

minrk opened this issue Aug 11, 2018 · 12 comments

Comments

@minrk
Copy link
Collaborator

minrk commented Aug 11, 2018

cc @SylvainCorlay

basic widgets don't seem to be working right now:

from ipywidgets import *
IntSlider(5)

gives Error displaying widget. js console shows:

TypeError: this.handle.stop is not a function. (In 'this.handle.stop(1,1)', 'this.handle.stop' is undefined)

TypeError: this.handle.stop is not a function. (In 'this.handle.stop(1,1)', 'this.handle.stop' is undefined)
_refreshValue — slider.js:654
https://unpkg.com/thebelab
_refresh — slider.js:106
https://unpkg.com/thebelab
_create — slider.js:97
https://unpkg.com/thebelab
_createWidget — widget.js:340
https://unpkg.com/thebelab
https://unpkg.com/thebelab
each — jquery.slim.js:354
https://unpkg.com/thebelab
render — widget_int.js:127
https://unpkg.com/thebelab
promiseReactionJob

Maybe a version mismatch?

Reported by @lukasheinrich

@SylvainCorlay
Copy link
Collaborator

I am afk but was just testing on my phone. The Label appears to work but not the slider.

I cannot troubleshoot right now. Could it be an issue with the jqueryui version? Cc @jasongrout

@lukasheinrich
Copy link

@SylvainCorlay
Copy link
Collaborator

SylvainCorlay commented Aug 11, 2018

Yes, The slider is the only widget making use of jqueryui and "stop" refers to a method of the jqueryui slider handle.

We need to check if there was a breaking change in jqueryui and the requirement in package.json for @jupyter-widgets/controls.

@SylvainCorlay
Copy link
Collaborator

@minrk I have opened a PR fixing this. The issue came from the use of the "slim" version of jquery.

@minrk minrk closed this as completed in #73 Aug 12, 2018
@minrk
Copy link
Collaborator Author

minrk commented Aug 12, 2018

@SylvainCorlay thanks for finding and fixing it! Published 0.3.3 with this (and your restart button).

@lukasheinrich
Copy link

great! works on minrk.github.io now that the package is updated on npm. Thanks!
screenshot

@lukasheinrich
Copy link

actually interact(...) seems to still break, while the IntSlider works. Tested on minrk.github.io and locally with an updated 0.3.3

screenshot

@SylvainCorlay
Copy link
Collaborator

Interact will need some work with the Output widget, which is a bit more involved.

@SylvainCorlay
Copy link
Collaborator

@SylvainCorlay thanks for finding and fixing it! Published 0.3.3 with this (and your restart button).

Thanks @minrk I will push out an example with C++ tomorrow :)

@lukasheinrich
Copy link

@SylvainCorlay can you give some detail what kind of work will be needed, we would like to contribute to making sliders etc work.

@SylvainCorlay
Copy link
Collaborator

So all basic widgets should be working on thebelab.

The interact function depends on Output widget needs to be implemented for thebelab. The output widget implementation is different on jupyterlab, or the classic notebook and will likely be closer to that of jupyterlab here.

@lukasheinrich
Copy link

thanks @SylvainCorlay. I see an output widget being implemented here https://github.com/minrk/thebelab/blob/master/src/output.js . Does this just need to be extended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants