Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

irmin-pack: improve control file's atomic write properties #2181

Closed
metanivek opened this issue Jan 31, 2023 · 1 comment
Closed

irmin-pack: improve control file's atomic write properties #2181

metanivek opened this issue Jan 31, 2023 · 1 comment

Comments

@metanivek
Copy link
Member

Currently, we assume that writes are atomic because the control file is small enough to fit within a page. We could improve this by using a known mechanism for atomic updates, like writing to a temporary file and renaming it.

Context https://github.com/mirage/irmin/pull/2180/files/7b9e971b221b577c26dd533f9f8853bf77967325#r1090672123
@metanivek metanivek mentioned this issue Jan 31, 2023
Merged
@metanivek
Copy link
Member Author

Implemented in #2206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@metanivek