Explicitly specify project root for poetry #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Projects with nested `pyproject.toml` may pick up the incorrect file
relative to the `.mise(.local)?.toml` if the working directory is deeper
than a nested file.
This can lead to a (shared) virtual-environment at the top-level not
being activated.
```
project/ <-- VIRTUAL_ENV/POETRY_ACTIVE set as expected
.mise.toml
.venv/ <-- shared by sub-projects
pyproject.toml
sub-project/ <-- VIRTUAL_ENV/POETRY_ACTIVE not set
pyproject.toml
```
This change infers the poetry project directory from the
`pyproject.toml` file. If virtual-environments are desired for the
sub-projects, then a `.mise.toml` can be created in those directories.
|
Thank you, @jdx ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projects with nested
pyproject.tomlmay pick up the incorrect file relative to the.mise(.local)?.tomlif the working directory is deeper than a nested file.This can lead to a (shared) virtual-environment at the top-level not being activated.
This change infers the poetry project directory from the
pyproject.tomlfile. If virtual-environments are desired for the sub-projects, then a.mise.tomlcan be created in those directories.