perf: throttle keyboard input to improve responsiveness #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
added a commit
to nolanlawson/emoji-mart
that referenced
this pull request
Mar 10, 2019
perf: throttle keyboard input to improve responsiveness
nolanlawson
added a commit
to nolanlawson/emoji-mart
that referenced
this pull request
Mar 10, 2019
perf: throttle keyboard input to improve responsiveness
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responsiveness while typing in the search bar can be sluggish, because we are updating on every
changeevent. With this PR, we throttle the change listener based onrequestIdleCallback/setTimeoutto avoid sluggishness.The easiest way to reproduce this is to put the Chrome Dev Tools on 6x slowdown, and then type very fast. Especially when deleting the first letter, you can feel the delay.