Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ルーター定義に含まれないローカルURLのMkUrlPreviewによる遷移が正しく動作しない #13490

Closed
1 task
zyoshoka opened this issue Mar 2, 2024 · 1 comment · Fixed by #13509
Labels
⚠️bug? This might be a bug

Comments

@zyoshoka
Copy link
Contributor

zyoshoka commented Mar 2, 2024

💡 Summary

ルーター定義1に含まれない ${host}/api-doc${host}/twemoji/2764.svg などの URL を MkUrlPreview で表示させ、そのリンクをクリックすると not-found ページに遷移してしまいます。

cf. https://misskey.io/notes/9qcsaaale1bg03iq

🥰 Expected Behavior

正しく遷移する

🤬 Actual Behavior

正しく遷移しない

📝 Steps to Reproduce

  1. URL ${host}/api-doc を含んだノートを投稿
  2. そのノートの URL をクリック

💻 Frontend Environment

* Model and OS of the device(s):
* Browser:
* Server URL:
* Misskey: 2024.3.0

🛰 Backend Environment (for server admin)

No response

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request

Footnotes

  1. https://github.com/misskey-dev/misskey/blob/f70489193270a689e37b8f31f6563471a26eaee5/packages/frontend/src/router/definition.ts

@zyoshoka zyoshoka added the ⚠️bug? This might be a bug label Mar 2, 2024
@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Mar 4, 2024

routerで無理ならlocation.hrefで飛ばすようにすれば良さそう

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug
Projects
Status: Done
2 participants