Fixing version check and catch statement in get_vm_status #7487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the version of Hyper-V instead of Powershell to determine which exception is thrown by Get-VM. Also fixing an invalid catch statement, since Powershell can not use variables to match thrown exceptions in catch.
|
This is an additional fix to the issue #7447, which duplicates the catch statement fix, but also works on Windows 2012 server which has a different version of Hyper-V. |
|
👍 this looks good to me and works well on my win 10 machine. I can also confirm the version check is correct for win 2012r2 both with and without wmf5. |
Closed
|
Thanks! |
|
+1 Thanks a lot! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the version of Hyper-V instead of Powershell to determine which
exception is thrown by Get-VM. Also fixing an invalid catch statement,
since Powershell can not use variables to match thrown exceptions in
catch.