-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash maybe related conflicting BPM values #10350
Comments
Commented by: daschuer Please look for a mixxx.log file with a number prefix from your crashing run. It likely contains more info about the crash. Copy the tailing lines here. Can you remember which track was involved in the crash? If it was a M4A/AAC file, you likely suffer this bug: https://bugs.launchpad.net/mixxx/+bug/1899242 |
Commented by: ronso0 In more recent 2.3 builds there is a shortcut :) Preferences > Lbrary > (at the bottom) Open Settings Folder |
Commented by: kek001 I am using 8078. This the tail of log, begin is just normal start procedure. there is no other info at end, because of fatal crash.
|
Commented by: kek001 Actually now when I am testing this problem. The crash can happend when loading mp3 track. so i dont know is this preview related or not. Not every track, but its happening, i dont know whats going on. I tried one track which crashed, doing clean grid and bmp, and wave. Earlier i tried preview my playlist about 80 song they went well, so its pretty confusing. |
Commented by: kek001 I installed 8083 oke, first run, it crashed, and second run it didnt crash it. last tail of log.
|
Commented by: uklotzde Without a backtrace we won't be able to analyze your crashes: https://github.com/mixxxdj/mixxx/wiki/creating_backtraces |
Commented by: kek001 Oke I will try to do it, because now its crashing also when try to analyze tracks, not every time This is so wierd. I will try to go an older version what i know was working and then try to do that backtrace. |
Commented by: kek001 This is not anymore preview problem. |
Commented by: uklotzde Since no one else reported any issues and the crashes seem to appear randomly this is probably an issue with your system (hardware, OS, graphics driver) and not Mixxx in particular. |
Commented by: Be-ing It's plausible it's a problem with kek001's computer rather than Mixxx, but we don't have enough information yet to know. |
Commented by: kek001 I just made a observation, it may a conflict with BPM. Because all my "old" tracks plays well, but i have problem with tracks i have analyzed after updating I could fix crashing tracks, the column where is BPM (C_BPM) its not same what is in the DECK BPM (D_BPM). Like one track C_BPM was 115 also when I clicked it. but the D_BPM was something like 114.97. The track name is Kindom Within. and there is other one too. I saw also other situation a tracks where C_BPM value after click it, was different than D_BPM and when i change value of C_BMP it didnt crash. THis is what i think now but it may change while I study this more. |
Commented by: Be-ing Thank you, that is helpful information. Considering this appears to be a regression from a recent change, I think we should take care of it before releasing 2.3.0. |
Commented by: kek001 No problem, I will be very happy when could start using mixxx 2.3 full speed. |
Commented by: kek001 I see often these when there are decimal numbers in BPM. like i click track where was decimals, it loaded well, but when try to load next track it crash or sometimes immediately. Still using build 8083, and now i know how to deal the situation, i can avoid the crash, or not use a track. First i was thinking there could be a problem with mp3 and used mp3 diags application. This crash can happend during loading a track to deck, or sending them for analyze or just click the BMP value on deck, or using preview. Maybe samplers too, havent test it. |
Commented by: kek001 mistake: "Just click the BMP value on deck"----> i meant BPM column |
Commented by: Be-ing This seems to be a problem with BeatGrid rather than decoding the audio. |
Commented by: uklotzde I remember that I explicitly tested resetting and re-analyzing the BPM of MP3 files that only store an integer number in file tags. We need to find out the exact steps that cause such a crash. |
Commented by: uklotzde I am not able to trigger a crash when messing around with BPM values. Even not if reanalyzing, playing, and previewing the same track at once. |
Commented by: kek001 Windows 10, The track what i wrote above, shows deck area 114.96, library column it shows 115 the value after click and reanalyze shows 114.96xxxxx if i dont enter 115, it will crash while loading Kindom within track which is mp3 and same kind of thing happening some other tracks too. |
Commented by: uklotzde
|
Commented by: uklotzde All the tracks from the release have integer bpms when analyzed with the latest version. But even if I tap or edit the bpm and then re-analyze nothing weird happens. |
Commented by: uklotzde We need Windows backtraces in case this issue only affects Windows. |
Commented by: Holzhaus @kek001 did you untick "Assume constant tempo" in the beat detection preferences? If you are worried about your database, you can just back up your mixxx user directory: https://manual.mixxx.org/2.3/en/chapters/getting_started.html#upgrading-mixxx |
Commented by: uklotzde
-> critical [Main] DEBUG ASSERT: "!"BeatMap::setBpm() not implemented"" in function virtual mixxx::BeatsPointer mixxx::BeatMap::setBpm(double) at ../src/track/beatmap.cpp:636 |
Commented by: uklotzde This DEBUG_ASSERT has not been modified since 5 years. |
Commented by: kek001 I do backups, i was more worried if sqlite database slowly degenerates and my backups will carry those untill it blows. Good to know it is hard as rockroach. |
Commented by: kek001 Update: I was thinking will clean mixxx folders and uninstall before doing backtrace, if problem still exist. I cleaned using revo uninstaller. and then installed latest build 8086, I was thinking i can have whatever kind of dll etc because installing so manyt times new builds. I dont know is it a new 8086 build or fresh set of dll's etc. Sorry if i have waisted your valuable time. It looks can close this, i will stress test mixxx if i can crash it, so far looks good. |
Commented by: kek001 dang crash. and seconds crash.so going to backtrace route |
Commented by: kek001 i tried run x64dbg. please look attachment of screenshot. |
Commented by: uklotzde Ok, looks like another debug assertion triggered that reveals an inconsistency between the beat grid and the nominal value stored as metadata. This should happen on any platform, not only Windows. We need to know how you use and how you are able to get there. It might also depend on your settings, namely Library and Beat Detection. |
Commented by: kek001 this is moment when mixxx crash, i loaded decimal track thats it. showing text loading track. |
Commented by: kek001 @uwe Klotz "It might also depend on your settings, namely Library and Beat Detection." WHat you mean ?, there are not lot things what i can set in preferences, directory path is very simple But now for debugging i copy configs etc.. to default mixxx folder. BPM enabled, queen mary, assume constant beat. |
Commented by: Holzhaus @kek001 Please the pull request that Uwe linked aboce and check if you can still trigger the crash. Instructions can be found here: https://github.com/mixxxdj/mixxx/wiki/Testing#github-pull-requests |
Commented by: Holzhaus *Please test |
Commented by: kek001 I tested head 8090, ~70 tracks decimals and then other tracks, included tracks which earlier crashed. It looks good no crash. I will try to do a set later. Then I can verify it works, not want say yes and then no again. |
Commented by: kek001 Sometimes have to be happy because couldnt do something or achieve. |
Issue closed with status Fix Released. |
Reported by: kek001
Date: 2021-03-16T06:05:57Z
Status: Fix Released
Importance: Critical
Launchpad Issue: lp1919278
Tags: windows
Attachments: [debug shot](https://bugs.launchpad.net/bugs/1919278/+attachment/5477634/+files/debug shot)
2.3beta
Windows 10. After using preview column (icon) for couple song mixxx do a fatal crash.
The text was updated successfully, but these errors were encountered: