Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'no effect' to (quick) effect chain selector #10777

Closed
mixxxbot opened this issue Aug 23, 2022 · 2 comments · Fixed by #10859
Closed

add 'no effect' to (quick) effect chain selector #10777

mixxxbot opened this issue Aug 23, 2022 · 2 comments · Fixed by #10859

Comments

@mixxxbot
Copy link
Collaborator

Reported by: ronso0
Date: 2022-07-05T15:22:04Z
Status: In Progress
Importance: Wishlist
Launchpad Issue: lp1980755
Tags: effects, gui, preferences


It would be helpful to have an empty (quick effect) chain available by default.
Furthermore, I think a 'clear effect unit' action in the effect chain settings menu would be a welcome shortcut to clear a unit.

I want to disable all stuff in the audio chain I don't use, both because it's one more thing I'd need to check if something goes wrong (yes, that happens) and because I want to get rid of visual clutter (in the mixer).

Before the effects refactoring there was a '---' Quick Effect item in the EQ preferences which did exactly that. After the refactoring, the quick effect selector was restored in the prefs, though the 'empty' item is just a blank item, not recognized by / retrieved from the effects engine, and thus not valid or available in the quick effect selector.

My current workaround is store an empty chain, go to prefs, drag (copy) it to Quick Effect chains, then select it in the prefs (or mixer).

Would a fix be as easy as having a built-in empty chain?
(named '---' like other [empty] selectors)

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2022-07-05T15:48:47Z


My guess is yes.

@mixxxbot
Copy link
Collaborator Author

mixxxbot commented Aug 23, 2022

Commented by: ronso0
Date: 2022-08-12T20:13:09Z


Turns out a built-in empyt chain preset is not suitable because it can be edited which defeats the purpose. Instead I went the route to work with the '---' items in the comboboxes and adjust the effects manager to deal with that.

#4892
#10859

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.4.0 milestone Aug 24, 2022
@ronso0 ronso0 linked a pull request Sep 4, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant