-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings menu is unreadable when theme changes in the evening with default MacOS configuration #13643
Comments
Nope, all dialogs use the Qt / system theme. How do the pages look like when you set the bright OS theme? |
and which macOS and Mixxx version do you use? |
Looks like it's fixed on restart. M1 Max, Sonoma 14.6.1, iirc the latest. I think the issue likely happens when the system theme changes during runtime. And yeah all the preferences pages looked like that. |
Yeah okay, confirmed - I can reproduce it by opening Mixxx and then swapping the system theme from System Preferences between light/dark. |
Okay, thanks for checking. Is the theme updated in other apps' settings/dialogs? |
If restarting Mixxx fixes it, it's probably just an unintended consequence of assuming that the theme doesn't change while the app is running (IIRC we do that for localization and a few other things too, probably out of convenience). I agree that the interaction with automatic theme changes is unfortunate. I'm not familiar enough with our styling to say how much of this Qt is responsible for and how much we are, but my gut feeling is that it's probably something on Qt's side, so maybe worth searching for relevant issues there.
Yes, most apps I've encountered on macOS handle "hot" color scheme changes correctly (almost all Cocoa apps, Firefox, VSCode, GTK4 apps). |
Bug Description
When the system theme changes in the evening, some styles seem to be updated and others don't, resulting in unreadable text in all preferences menus.
Lots of the text is near-white on light-grey.
I have not set any custom QT themes, this is a bare install with default settings.
Version
Mixxx 2.4.1 on MacOS - 2021 M1 Max running Sonoma 14.6.1, installed with homebrew cask.
OS
No response
The text was updated successfully, but these errors were encountered: