-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show minute markers on overview waveform #5843
Comments
Commented by: esbrandt Right on, this would be helpful. |
Commented by: rryan I guess my main question is how to indicate that they are minute markers instead of hotcues or cue markers. Should we draw the minute they represent on it? That might look ugly. Some other way? |
Commented by: allenbina
|
Commented by: ywwg If anything, measure and phrase markers would be more useful but then we'd have to have code for time signatures and phrase length. |
Commented by: shetyeakash How about this patch, although the approximation of the value of oneMinute is based on observation alone and no calculations are done for getting it. Some help there please .... the markers are drawn as white lines behind the waveform, much like the 4 divisions that are default. To avoid confusion with the default white markers on waveform please move the file "mixxx-1..../res/skins/(whichever skin you use)/style/style_bg_woverview.png" somewhere else so the default 4 divisions won't appear. |
Commented by: shetyeakash Thanks to Thomas, here is an updated patch that will work in all situations for songs with different sampling rates, I've tried it out with couple of songs. Please move the waveform backgroung .png file in yout skin folder somewhere else as mention in the above comment ^^. |
Commented by: maxime-bochon This topic deserves to be generalized. The user should be able to display an "overall grid" or not, and to choose how that grid is built through the preference dialog. Among others: a) "Minute markers" generalized to "fixed time interval markers" : useful to quickly jump to a point in a 60-min mix or a raw vinyl rip. b) "4 bar markers" (cf. bug #992923) generalized to "beat-sync markers" : the same as a) but in a musical manner (this requires the beat-grid and first beat to be known) (so for now restricted to track with fixed and steady tempo, with first beat set manually). c) "Segment markers" : useful to separate segments based on any segmentation method, such as tonality (to know where the key changes), or level (to jump to the start of a track in a raw vinyl record where there is a few seconds of silence) or even song structure (verse, chorus, bridge...). For case c), I know that some audio formats (such as Wave) can embed time markers as meta-data, so this could be a way of importing a custom overall-grid. |
Commented by: naught101 If there was bar-detection, bar markers every 4 bars would be pretty useful. Even if there isn't bar detection, a marker every 16 or 32 beats (depending on the tempo) would be good enough.. This would provide useful reference points for "how far am I from the next phrase". Markers could perhaps be a just a short 3-5px vertical line at the top and/or bottom of the waveform, to distinguish from cue markers. |
Commented by: daschuer This is really an issue, we should solve. I usually set a the cue point to the first down beat of the track and starting the track counting the previous one. The quantized play feature helps me to start the new track in time. What is you use case of the down beat markers? I think as a base for this feature, we need at least a measure column in library, that tells use how many beats we have per downbeat, and a hidden info where the first one is. Could be a GSoC project. .... |
Commented by: Pegasus-RPG Or rather a time signature column so we can support various types of music. |
Commented by: Be-ing Beats per measure awareness and display are a separate feature and use case from time markers on the overviews. I think the discussion about that should continue on Bug #753301. Time markers on the overviews would be helpful for visually estimating how much time two tracks could overlap without regard to rhythm. |
Commented by: daschuer Yes I meant actually a time signature column. |
Commented by: ywwg bumping this -- it would be really nice to have markings every 16 or 32 bars. Even though this isn't a universally-correct value, it would still allow for better visual alignment even if the tracks weren't in 4/4. I would strongly prefer marking beats instead of time. Since the tracks get stretched with the rate slider, the time values are pretty useless -- and I can already estimate time by looking at the existing indicators. |
Commented by: ywwg For tracks without beatgrids we could mark the minutes and use a different color, for instance. But I'd prefer not to block this feature on edge cases before looking at how well it works in the common case. |
Commented by: ronso0 I'm pro minute markers actually. beat/phrase markers in the overviews are not really helpful IMO. |
Commented by: ywwg maybe it's best to hack up a proof of concept and we can play around with different ideas? I think a minute isn't enough granularity for what I want, which is to make sure my drops line up :) |
Commented by: ronso0 we should keep it open IMO. |
Commented by: Be-ing
Yes, this is an unresolved issue.
I understand what you're going for, but I don't think adding minute markers to the overviews would really be very helpful. It could only provide rough estimates of times. If the markers were placed more frequently to provide better estimates, the appearance would become more cluttered. Right clicking the waveform or showing the time of cue points can show exact times without the clutter of always showing information that is only wanted sometimes. |
Commented by: foss-4 I understand why this may be desired and yet I think this would not work that great in practice. For really long (or short) tracks minute markers would be useless. And also this takes away focus from other things already going on in the waveform view. Especially with hotcue namings and intro markers arriving. Thus I would propose to close this as wontfix. |
Commented by: ronso0
That's exactly what their purpose would be (for me).
It's a good thing that intro markers for example are visible only if the respective cue tray is enabled. |
Commented by: ronso0 This is a valid feature request, so simply closing it because it bad/ugly implementations are possible is wrong IMO. |
Commented by: Be-ing It's not about the implementation. I think the whole idea is unnecessary clutter with better ways to get time information from the waveform. Let's not add minimally useful features that many (if not most) users will want to disable anyway. Keeping every years-old idea open in the bug tracker only creates an unmanageable list of things that will never happen. |
Commented by: devinyl Hi I'm willing to take over the fix, but I need some technical support how to deal with the current rescaling /transformations of the waveform overview. |
Commented by: devinyl Thanks, I will have a look. As I was able to follow the discussions, the downbeat markers are related to the scrolling waveform, but the minute markers have a different intention: they help (at least for me) to find the right point in time to start the mix. I started to use MIXXX as I've switched my whole IT infrastructure to linux, but the dj software was one of the last tool I struggle with. I'm an old school DJ with more than 23 years of experience in playing Trance Music at our own events https://www.facebook.com/lunaticevents.ch, starting with Vinyl on MKII, then we moved slowly to Serato Scratch with Time Coded Vinyl. In Mixxx I currently miss the minute markers on the overview, as we play on the newest Nexus Pioneer mixers, and they have simple but effective minute markers to compare the tracks. |
Commented by: Be-ing
I understand what you are asking for and this proposal for time markers on the overview waveforms is not precise enough to do what you're trying to do. For this you need to mark the intro and outro sections: I know Traktor shows minute markers on the overview waveforms. I find this to be visual clutter because it's not really useful. That only works as a very crude way to compare the lengths of tracks, but it can't be used to determine when to press play and know that the tracks will align how you intend. |
Commented by: devinyl Hi Sorry for the late answer, too much work and holiday. |
Commented by: devinyl and a second screenshot with parallel waveforms |
Commented by: Be-ing IMO it is a waste of time to implement and discuss such hacks when better solutions are being actively developed. |
Commented by: andy-xyz please make markers in the waveform overview, I don't use a mouse for djing |
Commented by: devinyl I'm testing the new feature "New Beats with UI". I like it, as it gives me enough details for mixing. |
Commented by: Be-ing
The best way to solve this would be putting the the two waveforms adjacent to each other. I made a mockup for how such a design could work a while ago but no one has started working on such a skin.
That's an interesting idea and a separate topic from this requested feature.
That is what the intro and outro cues are for. https://mixxx.org/news/2020-07-09-intro-outro-sections/ |
Commented by: nm2107 Hello, Minute markers would be a nice feature IMHO, I'm also lacking them (i.e. like on Traktor, on the global track waveform). This time indication can help to take mixing decisions, e.g. can I start playing the next track now/from that cuepoint or should I wait some more bars/jump to the next cuepoint instead ? 👍 for having an option for this, in case where users do not want them. |
Commented by: daschuer Mixxx 2.3 will have a cursor with minutes anotations on the right click. If yes, I think we can close this bug in favor to not clutter the waveform more. |
Commented by: devinyl @daniel thanks for pointing out. I made already a feasibility for the minute markers, but the markers currently don't change when resizing the window, and I don't know how to make it configurable. I will incorporate the changes on a branch and will come back soon (hopefully within the next years :) |
Commented by: Be-ing Have you used the intro and outro cues as suggested months ago? |
Commented by: nm2107 Thanks for your answers. I have not tried the intro and outro cues yet, but as far as I understand this feature, it implies :
So the above cases are convenient, but IMHO they do not cover the cases for simple minute markers on the waveform, which are :
I hope this describes more why we're requesting for such feature ^^. It's mostly to be able to quickly identify the duration of a song part. |
Commented by: Be-ing I don't think further discussion is useful here without the people advocating this change trying to use the intro and outro cues as they are designed. |
Commented by: fas-ubuntu Hello, from my experience minute markers in Traktor help getting a feeling of time. In electronic music like Techno and House this is quite useful as the tracks are basically arranged as 32 Beat Blocks (you know 32 beats, then a repitition or change). And this visually helps to see the time as size in the waveform. Intro/Outro cues have a completely different purpose. |
Mixxx 2.4.1 with minute markers on the overview waveform. https://github.com/ChrisTallon/mixxx/tree/2.4.1-minutemarkers To build, follow all the normal instructions but use this git-clone command instead: git clone -b 2.4.1-minutemarkers https://github.com/ChrisTallon/mixxx.git This is a quick hack job.... Comments welcome. |
Hi @ChrisTallon if you intend to get your changes included in mixxx, please open a pull request. See https://github.com/mixxxdj/mixxx/wiki/Contribution%20Guidelines |
This has been implemented in Mixxx 2.6 by @ChrisTallon in #13401. Thank you very much. |
Reported by: raffitea
Date: 2011-03-31T13:59:28Z
Status: Confirmed
Importance: Wishlist
Launchpad Issue: lp746456
Tags: easy, weekend
Attachments: minutemarker.patch, [This patch solves the mentioned bug.](https://bugs.launchpad.net/bugs/746456/+attachment/2732176/+files/This patch solves the mentioned bug.), [Minute Markers 2](https://bugs.launchpad.net/bugs/746456/+attachment/5411922/+files/Minute Markers 2), [Minute Markers with parallel waverforsm](https://bugs.launchpad.net/bugs/746456/+attachment/5411923/+files/Minute Markers with parallel waverforsm), skin-mockup.png
Some skins like NightLightBlues have "markers" on the overview waveform but their distances are not 60 seconds long. I think we should introduce minute markers for that purpose.
The text was updated successfully, but these errors were encountered: