Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to mark history as "already played" #8948

Closed
mixxxbot opened this issue Aug 23, 2022 · 4 comments
Closed

Add option to mark history as "already played" #8948

mixxxbot opened this issue Aug 23, 2022 · 4 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: LindyBalboa
Date: 2017-10-07T07:29:08Z
Status: Confirmed
Importance: Wishlist
Launchpad Issue: lp1721929
Tags: easy, library


For dance DJs, it is a common occurence to play to the same crowd 2 or 3 days in a row. It would be useful to be able to mark all the tracks from the previous days set as "played".

An alternative would be to make sessions explicit, saved, and loadable. However I think that would require more work to implement and the option to mark arbitrary tracks/playlists as already played is more atomic.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2017-10-07T09:01:48Z


Yes, that schould be easy to implement.
Do you have fun to look into it yourselves?
If yes, I can give you some hints.

As a workaround, you can merge two history playlists, all played flags are adopted from the merged playlist as well.

@mixxxbot
Copy link
Collaborator Author

Commented by: LindyBalboa
Date: 2017-10-07T09:23:07Z


Yea I could take a stab. No promises on a timeline though.

It seems marking as played and updating the play count on a track are coupled. So I guess it would be a matter of splitting those actions and just recursing through the playlist to do so? Although your workaround implies that those actions might not be coupled. Please suggest away though, you know the code base better than I.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2017-10-07T16:13:25Z


We have void SetlogFeature::slotJoinWithPrevious() to join an old history with the current
The inner loop setting the played flag is at setlogfeature.cpp:214

A solution is to add context menu entry near setlogfeature.cpp:28
and introduce a new slot copying the slotJoinWithPrevious() solution, but removing the joining.

If there is a common part for both features, you may extract it as sub function, if you think it it worth to do.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@ronso0
Copy link
Member

ronso0 commented Feb 25, 2024

Fixed by #11574, available since Mixxx 2.4.0

@ronso0 ronso0 closed this as completed Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants