-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toEqual throws Range Error when objects with circular references are compared #50
Comments
I can submit a PR + tests(for checking circular reference) for this. |
@mayankchd I think it's a reasonable approache to use something that seems more maintained where all the bugs we need are fixed. DO it! |
This was referenced Dec 9, 2015
Released in v 1.13.1 |
Hm, maybe a bit of a regression here, I'm getting errors like these (extra line breaks mine):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As this package uses deep-equal to check for equality , similar issue has been filed on deep-equal 8 months ago .
I think using deeper for checking for equality would be good as it works when objects with circular references are compared.
It passed all the tests along with circular reference one .
The text was updated successfully, but these errors were encountered: