Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch button between desktop and mobile view prevents links to be clickable #191

Closed
ddeath opened this issue Nov 18, 2017 · 1 comment
Closed
Milestone

Comments

@ddeath
Copy link

ddeath commented Nov 18, 2017

When you have email links in position next to the switch button they are not clickable.

In this case "blogu" is not clickable.

non_clickable

Not a big deal, just mentioning it :)

@meriadec
Copy link
Contributor

Hi @ddeath, the code is here:

<div className="FileList--preview-actions-wrapper">
<div className="FileList--preview-actions">
<Button
ghost
className={cx({
isActive: previewSize.get('current') === previewSize.get('desktop'),
})}
onClick={() => onSetSize(previewSize.get('desktop'))}
>
{'Desktop'}
</Button>
<Button
ghost
className={cx({
isActive: previewSize.get('current') === previewSize.get('mobile'),
})}
onClick={() => onSetSize(previewSize.get('mobile'))}
>
{'Mobile'}
</Button>
</div>
</div>
I think it can be pretty easily solved by adding pointer-events: none, to the container, thenpointer-events: auto to the buttons. That will allow clicks to pass through transparent container.

@meriadec meriadec added this to the 2.9.0 milestone Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants