Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical-align attribute should be valign #2684

Closed
SebastianStehle opened this issue May 25, 2023 · 1 comment · Fixed by #2728
Closed

Vertical-align attribute should be valign #2684

SebastianStehle opened this issue May 25, 2023 · 1 comment · Fixed by #2728

Comments

@SebastianStehle
Copy link
Contributor

mjml/packages/mjml-column/src/index.js

Line 261 in 988819d

'vertical-align': component.getAttribute('vertical-align'),

See: https://www.w3resource.com/html/attributes/html-valign-attribute.php
@SebastianStehle SebastianStehle mentioned this issue May 25, 2023
Closed
@iRyusa
Copy link
Member

iRyusa commented May 25, 2023 •
edited
Loading

I'm not even sure this do anything, that can be removed

@garrettjohnson garrettjohnson mentioned this issue Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove invalid vertical-align property from column garrettjohnson/mjml
2 participants
@iRyusa @SebastianStehle