Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Multi-root support for upcoming VSCode release #112

Closed
WraithKenny opened this issue Oct 12, 2017 · 3 comments
Closed

Multi-root support for upcoming VSCode release #112

WraithKenny opened this issue Oct 12, 2017 · 3 comments

Comments

@WraithKenny
Copy link

VS Code will have support for multiple root folders in the next release, and vs-deploy will have to be updated to support it. Currently on the "Insiders" release, if you configure a multi-root project, and edit your Workspace Settings to contain only one folder, vs-deploy still works fine, but if you have more than 1 folder in the Workspace, things stop working as expected.

https://github.com/Microsoft/vscode/wiki/Extension-Authoring:-Adopting-Multi-Root-Workspace-APIs

@mkloubert mkloubert added the bug label Oct 13, 2017
@mkloubert
Copy link
Owner

@WraithKenny

Thank you very much for the feedback!

I will spend my time with refactoring to the new API, otherwise we have a non working extension here, when the upcoming release arrives!

@WraithKenny
Copy link
Author

WraithKenny commented Oct 31, 2017

Hello again! I've been thinking on this issue, and I've seen the commit were you refactored workspace.getRootPath(), which is great.

I'm thinking that the difference between window and resource is important to vs-deploy.
https://github.com/Microsoft/vscode/wiki/Extension-Authoring:-Adopting-Multi-Root-Workspace-APIs#settings

Currently, your settings are on the default (window) but might make more sense as resource. This means that the .vscode/settings.json file where we used to put our deploy config would still be used but on a rootFolder by rootFolder basis, which I think makes sense.

If the settings are window based, then users who move to multi-root project have to migrate to the xxx.code-workspace file, and more importantly its unclear to what folder(s) those settings would apply to (and would seem to need a much bigger code refactor to fully support settings for folders other than the first).

I can confirm that multi-root is working, provided that the settings defined in xxx.code-workspace are assumed to apply to the first folder in the array (folders[0].path).

Thanks for your hard work!

@mkloubert mkloubert added enhancement and removed bug labels Nov 20, 2017
@mkloubert
Copy link
Owner

Should be have a much better support in new extension.

That you very very much for your help! @WraithKenny

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants