From ab121238115745f7e0b579b0309fcebc365c6b3f Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Mon, 26 Aug 2019 11:36:50 +0800 Subject: [PATCH] install-deps.sh: download wheel using 'pip wheel' otherwise we will fail to install the build dependencies of `lazy-object-proxy` from the wheelhouse. as `lazy-object-proxy` does not add `setuptools_scm` in its `setup.py`, instead it lists `setuptools_scm` in `setup.cfg` and `pyproject.toml` as a `build-system` requires. but unfortunately, `pip download` only downloads the install/run-time dependencies at this moment. and `lazy-object-proxy` does not offer binary package for at least python2.7. ideally, `pip download` should collects its dependencies like Collecting setuptools_scm>=3.3.1 (from lazy-object-proxy->astroid<3,>=2.2.0->pylint->-r requirements-lint.txt (line 1)) so we need to use `pip wheel` do download build-time dependencies see also https://github.com/pypa/pip/issues/6222 Signed-off-by: Kefu Chai --- install-deps.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/install-deps.sh b/install-deps.sh index 0df7fdd80c3812..a5f91b9a1d6ef6 100755 --- a/install-deps.sh +++ b/install-deps.sh @@ -497,7 +497,7 @@ find . -name tox.ini | while read ini ; do for interpreter in python2.7 python3 ; do type $interpreter > /dev/null 2>&1 || continue activate_virtualenv $top_srcdir $interpreter || exit 1 - populate_wheelhouse "download -d $wip_wheelhouse" $require $constraint || exit 1 + populate_wheelhouse "wheel -w $wip_wheelhouse" $require $constraint || exit 1 done mv $wip_wheelhouse wheelhouse md5sum $require_files $constraint_files > $md5