Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code2FN] Remaining Python Files for CISM Ingestion #774

Open
2 tasks
titomeister opened this issue Jan 25, 2024 · 1 comment
Open
2 tasks

[code2FN] Remaining Python Files for CISM Ingestion #774

titomeister opened this issue Jan 25, 2024 · 1 comment
Assignees
Labels
Code2FN Proposed This is a label for proposed future issues to be addressed beyond ASKEM phase 1

Comments

@titomeister
Copy link
Contributor

Currently the Code2FN pipeline can ingest 50 out of the 52 Python files in the CISM model.
The bulk of them were taken care of due to Vincent's Python 2 to Python 3 conversion.

The last two files have some other issues involving Python generation.
Investigate what's causing the issues and resolve them.

Tasks

@titomeister titomeister self-assigned this Jan 25, 2024
@titomeister
Copy link
Contributor Author

titomeister commented Jan 30, 2024

Update 01/30/24
I've done some looking into the files, to see what they consist of and what pieces are breaking.

utils/build/generate_ncvars.py

  • This file seems to be used for generating the source code files for variable definition files. It contains mainly tools for 'printing' variable definitions according to some templates. It doesn't seem to have anything to do with scientific computation, but more with displaying data.
  • The main bugs with this file in the Python to CAST generation are function calls of elements that are being accessed from lists, like x[foo].bar()
  • This hasn't been supported up to this point, as this hasn't come up. It's not super difficult to fix, but it is something that isn't supported, so it's breaking.

tests/viewNetCDF.py

  • This file contains a bunch of code to create a GUI to display Glimmer files. There's no scientific computation happening here it seems.
  • This has a more complicated issue. In particular there's some Python generation for an edge case of Assignment with a Binary Operation in an unusual place (Maybe on the left side of the assignment, perhaps in a list indexing).
  • This is more complicated to fix, and it may have some implications on some Gromet generation.

For now, we'll put this investigation on pause to work on more pressing issues.

@titomeister titomeister added the Proposed This is a label for proposed future issues to be addressed beyond ASKEM phase 1 label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code2FN Proposed This is a label for proposed future issues to be addressed beyond ASKEM phase 1
Projects
None yet
Development

No branches or pull requests

1 participant