New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for expected number of evals submission and measured times #452

Open

priyakasimbeg opened this issue Jul 25, 2023 · 0 comments

Assignees

Labels

Good First Issue

Contributor

priyakasimbeg commented Jul 25, 2023 •

edited

Loading

Description

Add CI test that checks if reported times and number of evals are inline with expectations.

For each submission we report:

total wall clock time
submission time
eval time
logging time
number of evals

We should add the following tests on at least 1 workload (probably mnist).

We should check that submission_time + eval_time + logging time ~ total _wallclock_time.
We should check that the number of evals is roughly equal to total_submission_time // eval_period

priyakasimbeg self-assigned this

priyakasimbeg added the Good First Issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment