Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Define initial data objects for instance->prompt flow #4

Closed
wants to merge 14 commits into from
Closed

Define initial data objects for instance->prompt flow #4

wants to merge 14 commits into from

Conversation

brianwgoldman
Copy link
Contributor

Some notes:

  • Item+Reference is basically Instance+Reference from HELM, but is treated as immutable.
  • ItemPromptTemplate is intended to be what Adapter outputs, before window service specialization.
  • Prompt is intended to be reusable even if they come from multiturn humans, while Item should have a sibling class.
  • The purpose of the example.json files is to demonstrate what these objects look like when serialized.
  • I left a lot of TODOs as this was already getting too big.

@brianwgoldman
Set up poetry and validate it using a very basic pytest.
7df9132
@brianwgoldman
Run black
52bcfb1
@brianwgoldman
Introduce TraceableObject and import HELM's serialization strategy.
241b694 
TraceableObject can act as a base class, automatically creating unique identifiers and creation timestamps.
@brianwgoldman
A little better testing.
c229d06
@brianwgoldman
Define initial data objects for item->prompt flow.
016af82 
Some notes:

* Item is basically Instance from HELM, but is treated as immutable.
* ItemPromptTemplate is intended to be what Adapter outputs, before window service specialization.
* Prompt is intended to be reusable even if they come from multiturn humans, while Item should have a sibling class.
@brianwgoldman
Add round trip test for Item.
315773b
@brianwgoldman brianwgoldman requested a review from a team as a code owner November 16, 2023 15:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 16, 2023 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

bollacker
bollacker suggested changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@bollacker bollacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably my fault---- Let's use "Instance" instead of "Item".

https://docs.google.com/document/d/1DuNo2kjs4tUClIL5xR6RLLn5l13jTZUda1mUVboxm-4/edit?usp=sharing

@brianwgoldman brianwgoldman changed the base branch from auxy/traceable to main November 17, 2023 17:41
@brianwgoldman brianwgoldman changed the title Define initial data objects for item->prompt flow Define initial data objects for instance->prompt flow Nov 17, 2023
@brianwgoldman
Copy link
Contributor Author

Probably my fault---- Let's use "Instance" instead of "Item".

https://docs.google.com/document/d/1DuNo2kjs4tUClIL5xR6RLLn5l13jTZUda1mUVboxm-4/edit?usp=sharing

Done.

@brianwgoldman
Copy link
Contributor Author

This PR is very opinionated about how data flows through the system. I think #17's bare bones approach is likely better, especially once we decided to drop specializing to a SUT in #21.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bollacker bollacker Awaiting requested review from bollacker

Assignees

@yifanmai yifanmai

@bollacker bollacker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianwgoldman @bollacker @yifanmai