Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v 1.9.0 released today error with data.table 1.12.0 #155

Closed
mattdowle opened this issue Jan 10, 2019 · 1 comment
Closed

v 1.9.0 released today error with data.table 1.12.0 #155

mattdowle opened this issue Jan 10, 2019 · 1 comment

Comments

@mattdowle
Copy link

mattdowle commented Jan 10, 2019

Hi,
Rdatatable/data.table#3149 is fixed in data.table 1.12.0 so checking the old behaviour will fail here when data.table 1.12.0 goes to CRAN : https://github.com/mllg/checkmate/blob/master/tests/testthat/test_checkDataTable.R#L66.

* checking tests ... ERROR
  Running ‘test-all.R’
Running the tests in ‘tests/test-all.R’ failed.
Complete output:
  > library(testthat)
  > test_check("checkmate")
  Loading required package: checkmate
  ── 1. Failure: nrow for null data tables (@test_checkDataTable.R#66)  ──────────
  rownames(DT) not equal to as.character(1:3).
  Lengths differ: 0 is not 3
  
  ══ testthat results  ═══════════════════════════════════════════════════════════
  OK: 2917 SKIPPED: 1 FAILED: 1
  1. Failure: nrow for null data tables (@test_checkDataTable.R#66) 
  
  Error: testthat unit tests failed
  Execution halted

Please can you update either now or after data.table 1.12.0 is on CRAN is fine too.
Thanks, Matt

@mllg
Copy link
Owner

mllg commented Jan 10, 2019

Whoops, these lines should not have been released. Fixed in master, and ready to release a new version to CRAN as soon as needed.

@mllg mllg closed this as completed Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants