Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: open for PRs for extensions of checkmate? #228

Open
danielinteractive opened this issue Jul 15, 2022 · 3 comments
Open

Question: open for PRs for extensions of checkmate? #228

danielinteractive opened this issue Jul 15, 2022 · 3 comments

Comments

@danielinteractive
Copy link

Hi checkmate developers,

we are increasingly using checkmate for multiple packages and have been writing additional assertions etc. We are wondering whether you would be open for PRs with extensions of checkmate, or whether we should go for an add-on package (e.g. checkmate.extra or similar...). What are your thoughts on this?

Thanks,
cheers
Daniel

@tdeenes
Copy link
Contributor

tdeenes commented Jul 15, 2022

hi @danielinteractive , it is @mllg who is the right person to answer this question. Having said that, as someone who was an early adopter of checkmate (and made also minor contributions to it), I do not think it is worth extending checkmate further unless the given assertion is of really general use. In my experience, almost all custom assertions I create are somewhat specific to the particular problem I work on and therefore belongs to the given package.

Nevertheless, we could open a GitHub Discussion or an issue to collect the ideas for extensions. Everyone could add an entry to the list, and entries with many votes could be added to checkmate, or get included in a separate extension package. @mllg , your thoughts?

My candidate for a general-use assertion is assert_package, btw.

@mllg
Copy link
Owner

mllg commented Jul 21, 2022

I basically agree with @tdeenes: if the assertion is of general use and helpful for a broad range of applications, then checkmate is the right place for the assertion. Maybe you could be more concrete what kind of assertions you would like to see in the package.

Open a discussion also sound like a good idea.

@danielinteractive
Copy link
Author

Thank you @tdeenes and @mllg ! So we can come back with concrete proposals and then you can decide case by case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants