Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/addchain,internal/cli: return error from Execute() #34

Open
mmcloughlin opened this issue Feb 2, 2020 · 0 comments
Open

cmd/addchain,internal/cli: return error from Execute() #34

mmcloughlin opened this issue Feb 2, 2020 · 0 comments
Labels
cleanup General cleanup and code health low Low priority

Comments

@mmcloughlin
Copy link
Owner

Would the interface be cleaner if the Execute() method returned error instead of a status code. Might be easier for testscript-based testing.

Also wouldn't require two CheckClose helpers, added in #33.
@mmcloughlin mmcloughlin added cleanup General cleanup and code health low Low priority labels Feb 2, 2020
@mmcloughlin mmcloughlin added this to the Initial Release milestone Feb 2, 2020
@mmcloughlin mmcloughlin removed this from the Initial Release milestone May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup General cleanup and code health low Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmcloughlin