Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: extract from internal #125

Merged
merged 1 commit into from
Oct 27, 2021
Merged

meta: extract from internal #125

merged 1 commit into from
Oct 27, 2021

Conversation

mmcloughlin
Copy link
Owner

We intend to expose package metadata through the code generation interface
#94. If so, it seems wrong to publically expose an internal package. Instead
of duplicating data we'll just make it public instead.

@codecov-commenter
Copy link

Codecov Report

Merging #125 (06474fb) into master (71dd798) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   73.05%   73.05%           
=======================================
  Files          30       30           
  Lines        1874     1874           
=======================================
  Hits         1369     1369           
  Misses        445      445           
  Partials       60       60           
Flag Coverage Δ
unittests 73.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
meta/cite.go 0.00% <ø> (ø)
meta/meta.go 16.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71dd798...06474fb. Read the comment docs.

@mmcloughlin mmcloughlin merged commit d5342b5 into master Oct 27, 2021
@mmcloughlin mmcloughlin deleted the move-meta-pkg branch October 27, 2021 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants