-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to select dates in range format #32
Comments
There is not provision for that currently. I was thinking about it though, so might do some work to add this. |
The ability to select dates in range will be awesome! |
@mmick66 Will this be included in the project? Do you have any deadlines? |
I'll see if I can work on it today. |
@mmick66 Thanks a lot! |
I'd like to work on it. |
Great! @Omar-Kay. I recently implemented the ability to add new events. The trigger I selected is a long press, so I don't know how the user will be able to select ranges. Worst case we can find another way to add events. Go ahead and I will check your pull requests. Thanks! |
So I implemented on the cocoapods version a successful implementation of this feature, controlled by new a Also, left a video of showing the pod modified version ;). I didn't want to attach too much, but I've tested that when the flag is disabled, it works like before. Calendar view range selectable video.zip |
Nevermind! Got it to work on the main branch as well now! How do I initiate a merge request? |
Ran into this issue while trying to push. Any suggestions @mmick66 ? |
Great. This is probably because you are trying to merge to the main branch directly. I suspect that you just cloned the project and worked from there. What you should do rather is a pull request. The way it's done is that you need to create a pull request. To do that, fork the project (if you haven't already), include the changes in the forked repo, push them (it will be your repo so you should have all the privileges), and then go to the pull request tab and create a new pull request. Remember, a pull request is only created between forks. Good luck, and thank you for your work. |
Great, thanks for that! I've added a pull request |
@Omar-Kay: There are issues with your changes and I had to revert. Please check what happens when you select a range across months. Start from one month and finish in the next one for example. There is something wrong there. Also, another problem is when you select a range, deselect, and then try to select starting from the same date. In this case it does not select it. |
Is there a way to select dates by range instead of either daily or multiple days? So if a user selected Monday to Friday all days in between would be selected too.
The text was updated successfully, but these errors were encountered: