Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tooltips for links in masthead #1377

Closed
1 of 5 tasks
maazadeeb opened this issue Dec 1, 2017 · 4 comments
Closed
1 of 5 tasks

Support tooltips for links in masthead #1377

maazadeeb opened this issue Dec 1, 2017 · 4 comments

Comments

@maazadeeb
Copy link
Contributor

  • This is a question about using the theme.
  • This is a feature request.
  • I believe this to be a bug with the theme.
    • I have updated all gems with bundle update.
    • I have tested locally with bundle exec jekyll build.

Sometimes the text displayed in the masthead links are not descriptive enough. If we could have tooltips for the links, we could give more details about what the link represents. For example, "Tags" can have a tooltip "Posts grouped by tags" as a tooltip.

I think this can be supported by adding an extra field in the _navigation.yml called tooltip and use it in the masthead.html like this

<li class="masthead__menu-item"><a href="{{ domain }}{{ link.url }}" title="{{ link.tooltip | default = link.title }}">{{ link.title }}</a></li>

If it seems like a valid request, I would love to submit a PR for this.

@mmistakes
Copy link
Owner

Sounds good to me. Maybe to keep things simple just add title. The tooltip override seems unnecessary as I'm thinking most will just use title for the tooltip text anyways.

@maazadeeb maazadeeb changed the title Support tooltips for links in to masthead Support tooltips for links in masthead Dec 2, 2017
@maazadeeb
Copy link
Contributor Author

Alright. While I'm at it, do you think I could add tooltips to other links, like social media links for the author, the footer etc. ? I could change this issue as a general support for tooltips, if that makes sense.

@mmistakes
Copy link
Owner

Not sure how much value they'd add elsewhere. My feeling is most of the links are already descriptive of what they are. I want to avoid overcomplicating configuration and the templates.

@maazadeeb
Copy link
Contributor Author

Alright. Sounds good to me. I'll just change the links in the masthead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants