Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next release – Bump pybv requirement to 0.4 #621

Closed
hoechenberger opened this issue Nov 7, 2020 · 5 comments · Fixed by #626
Closed

Next release – Bump pybv requirement to 0.4 #621

hoechenberger opened this issue Nov 7, 2020 · 5 comments · Fixed by #626

Comments

@hoechenberger
Copy link
Member

We've fixed some serious issues here, which demand a new release; and I think once pybv 0.4 has been released, we should bump our requirement to that version, because otherwise we might end up writing … problematic BV files. WDYT?

cc @sappelhoff
@hoechenberger
Copy link
Member Author

See bids-standard/pybv#60

@sappelhoff
Copy link
Member

yes, definitely agreed 👍

@hoechenberger
Copy link
Member Author

Will 0.4 also fix the roundtrip issue we encountered recently?

@sappelhoff
Copy link
Member

yes, see sappelhoff/pybv#1 which is based off bids-standard/pybv#58

I'll open that PR properly once bids-standard/pybv#58 is merged, to avoid conflicts

@sappelhoff
Copy link
Member

done: https://github.com/bids-standard/pybv/releases/tag/v0.4.0

@sappelhoff sappelhoff mentioned this issue Nov 13, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] BUMP pybv 0.3 -> 0.4 sappelhoff/mne-bids
2 participants
@hoechenberger @sappelhoff