-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce Expected .fdt file format
error to warning
#12500
Comments
Hello! 👋 Thanks for opening your first issue here! ❤️ We will try to get back to you soon. 🚴 |
I can't easily test it, but based on what you're saying above @neuromechanist I take it that this file opens normally (no warnings/errors) in EEGLAB; can you confirm that? If so I'm a bit surprised because If you can load and then re-save the data in EEGLAB, and the re-saved file does load correctly in MNE, then I would hesitate about making MNE more flexible/permissive in what data it loads. The examples from the EEGLAB data structures docs don't mention this "in set file" as a valid value, so to me it doesn't make sense for MNE to treat it as though it were. cc @arnodelorme |
This is the warning for loading the same dataset in EEGLAB: pop_loadset(): ./sub-002_task-FacePerception_run-1_eeg_ON.set ...
Something is wrong with the data file, trying to use the associated .fdt file
Reading float file './sub-002_task-FacePerception_run-1_eeg_ON.fdt'...
Creating a new ALLEEG dataset 1
Done Yes, Under normal circumstances the in set file should not be created. However, the problem seems to be rooted in a resolved bug or custom code. See the twin issue on EEGLAB repo: sccn/eeglab#746 Nevertheless, the main point is the difference between handling exceptions in loading .set files between EEGLAB and MNE-Pyhton. EEGLAB would fall back to searching the directory if the string in Yes, Arno already has created an issue to correct this data set on NEMAR: sccn/NEMAR-pipeline#70. |
Thanks for the cross-refs. @arnodelorme says in sccn/eeglab#746:
(emphasis added) So the recommendation is "use EEGLAB to re-save the files." Is there a reason that's not satisfactory here? Or maybe a better question is: how common of a problem is this? E.g., if the corrupted files occur in multiple public datasets (not just the one that sccn/NEMAR-pipeline#70 will correct), then the problem will keep resurfacing over and over for different people. But if it's just the one dataset, you can re-export the files once and never hit it again. That said, checking for the presence of an |
Yes, I would recommend adding the behavior above as it is unclear how widespread this problem is. |
Description of the problem
In uncommon (usually stemming from custom code) cases where
EEG.data
is a string but does not point to the FDT file, this error prevents the user from loading the data:mne-python/mne/io/eeglab/eeglab.py
Line 56 in 14ff948
Since the following lines deal with the case of
data_fname
not being found, I suggest converting this error to a warning. EEGLAB also has a similar behavior, which falls back to searching the directory for the FDT file if theEEG.data
string does not point to the FDT.Steps to reproduce
Link to data
https://drive.google.com/drive/folders/18y0TALqwT4Z2yg4T6QafDAqIrY04jI5k?usp=sharing
Expected results
EEG will point to the data object.
Actual results
OSError: Expected .fdt file format. Found format
Additional information
The text was updated successfully, but these errors were encountered: