Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie editorial #350

Open
mnot opened this issue Sep 9, 2024 · 1 comment
Open

Cookie editorial #350

mnot opened this issue Sep 9, 2024 · 1 comment

Comments

@mnot
Copy link
Owner

mnot commented Sep 9, 2024

I have some feedback regarding the Cookie Section.

Note that this algorithm requires storing the cookies from the associated request with each response.

In Firefox we currently store a hash of the Cookie header instead of the actual cookie value in order to deal with Vary: Cookie.
This is because the cookies could be large in size, and because we don't want potentially sensitive information contained in cookies to be persisted in the HTTP cache.
So I think you can implement the algorithm without storing the actual cookies in the response.

I'm also wondering if this section should mention that the response may include a Set-Cookie header with one of the indices.
I don't think anything special would need to happen, apart from this immediately invalidating the cache entry.

@mnot
Copy link
Owner Author

mnot commented Sep 9, 2024

(From Valentine on list)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant