Use manifest/name as canvas label, to ensure uniqueness #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, it breaks if there are already annotations for that canvas. Hang on... |
|
It turns out it does matter if new annotations are added to a canvas that already has annotations. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3
I've just used the existing
manifestvariable to pass the manifest name to the two methods that write Jekyll-style Markdown headers for annotations lists. They compose the canvas label in the formmanifest + '/' + name. I haven't changed the annotations in the examples to use this form; they'll only have this problem if more examples are added that use the same canvas names as one of the existing ones.I've tested it with bnf640. The copperfield example isn't working for me (every annotation I create gets assigned to 10.json); I haven't investigated why.