Fix for NaN coming in time attribute when test fails. #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisjeffery
added a commit
that referenced
this pull request
Dec 6, 2013
Fix for NaN coming in time attribute when test fails. * vnikiti/xunit-sonar-fix: Fix for NaN coming in time attribute when test fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a test fails, division of duration property computes to NaN. An attempt to submit a report containing time="NaN" to Sonar throws an error and report gets rejected. To make Mocha XUnit compatible with Sonar, I propose this amazing change! This will return 0 when tests fail.