Less re-rendering with progress reporter #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a large number of small tests a significant portion of the testing time is simply re-rendering the progress bar, this only re-renders the progress bar if the progress has changed.
|
Is this actually a problem you're having? Seems surprising, but I'd be happy to merge it. |
|
It is, I have around 13,000 simple tests (a lot of this is testing calculations against reference data). Without this change the progress bar slows down the tests and flickers a lot while the tests run. |
|
Alright, thanks for the pull request - appreciate it! 👍 |
jbnicolai
pushed a commit
that referenced
this pull request
Jul 17, 2014
Less re-rendering with progress reporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a large number of small tests a significant portion of the testing time is simply re-rendering the progress bar, this only re-renders the progress bar if the progress has changed.