-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Feature: Add separate category for "skipped" tests besides "pending" #1815
Comments
The final output could be:
Introducing a new state for specs would be a major breaking change, so it'd have to target 3.0.0. I don't think this would be likely to get implemented in the near future. However, I do like the idea of distinguishing between the two. :) |
I'd like to voice that I think it's a very important feature. Could anyone with relevant knowledge elaborate on the "breaking changes" mentioned by @danielstjules? Is this something that could be reasonably contributed by an outsider? Additionally, I could imagine specifying a reason for the test being skipped to be quite useful as well. |
+1 I think we need a skipped status, currently we have to triage all "pending" tests and see when one is actually pending because of a failed hook or actually skipped. |
In principle I'm generally for being able to differentiate pending tests from tests that are skipped due to hook failures. (Something breaking in the test itself, on the other hand, should typically be a test failure rather than skipping.) That being said...
There are definitely custom (ie third-party) Mocha reporters relying on the current set of statuses. Additionally, there could (although it's both a hairier situation and a less likely one) be users or third-party tools parsing the reporter output that are likewise relying on the current set of statuses.
I don't have the link/number handy, but we do have an issue somewhere requesting this. What I'd like to point out here, however, is that this could potentially be an alternate resolution of the difference between pending and skipped: if |
Another use-case for skip: Writing tests for If Output that says |
This comment was marked as spam.
This comment was marked as spam.
Would anyone know a workaround for this issue? |
This would be a somewhat significant breaking change. I'm not against it, just per #5027 we're trying not to make any big changes any time soon. Marking as |
Summary example
You know, you can skip tests with
.skip()
and these appear in the summary at the end under thepending
category which is IMO not correct. Pending != Skipped. Pending can be interpreted as "not completed yet" whereas "skipped" can mean, code is not complete yet or is breaking for whatever reason.Any chance skipped tests can be summarised under a new group, i.E.
The text was updated successfully, but these errors were encountered: